From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
'Peter Griffin' <peter.griffin@linaro.org>
Cc: robh@kernel.org, conor+dt@kernel.org, linusw@kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
hajun.sung@samsung.com
Subject: Re: [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk
Date: Fri, 10 Jul 2026 12:00:10 +0200 [thread overview]
Message-ID: <9eb6b0ef-cbc1-4b2f-b607-986f28ec46ee@kernel.org> (raw)
In-Reply-To: <14cf01dd1052$4de88670$e9b99350$@samsung.com>
On 10/07/2026 11:55, Alim Akhtar wrote:
>>> ---
>>> arch/arm64/boot/dts/exynos/Makefile | 1 +
>>> .../boot/dts/exynos/exynos8855-pinctrl.dtsi | 574 ++++++++++++++++++
>>> .../arm64/boot/dts/exynos/exynos8855-smdk.dts | 32 +
>>> arch/arm64/boot/dts/exynos/exynos8855.dtsi | 204 +++++++
>>> 4 files changed, 811 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi
>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855.dtsi
>>> + };
> [snip]
>>> +
>>> + oscclk: clock-oscclk {
>>> + compatible = "fixed-clock";
>>> + clock-output-names = "oscclk";
>>> + #clock-cells = <0>;
>>> + };
>>
>> Small nit, but I believe oscclk node should be ordered alpha-numerically by the
>> node name. See https://docs.kernel.org/devicetree/bindings/dts-coding-
>> style.html
>>
> Thanks, will update in v4
The node feels ordered, no? clock before cpu?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-10 10:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260627165402epcas5p4481839961bdedebfa4d96a3517edaf2b@epcas5p4.samsung.com>
2026-06-27 17:12 ` [PATCH v3 0/6] Add minimal Exynos8855 SoC support Alim Akhtar
2026-06-27 17:12 ` [PATCH v3 1/6] dt-binding: ARM: samsung: Add Samsung Exynos8855 Alim Akhtar
2026-07-05 22:40 ` Ivaylo Ivanov
2026-07-06 3:44 ` Alim Akhtar
2026-07-06 7:57 ` Ivaylo Ivanov
2026-07-06 9:29 ` Alim Akhtar
2026-07-06 16:05 ` Krzysztof Kozlowski
2026-07-09 12:29 ` Peter Griffin
2026-07-09 12:31 ` Peter Griffin
2026-06-27 17:12 ` [PATCH v3 2/6] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible Alim Akhtar
2026-07-09 13:28 ` Peter Griffin
2026-06-27 17:12 ` [PATCH v3 3/6] pinctrl: samsung: Add Exynos8855 pinctrl configuration Alim Akhtar
2026-07-09 13:36 ` Peter Griffin
2026-06-27 17:12 ` [PATCH v3 4/6] dt-bindings: pinctrl: samsung: Add exynos8855-wakeup-eint compatible Alim Akhtar
2026-07-09 13:29 ` Peter Griffin
2026-06-27 17:12 ` [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk Alim Akhtar
2026-07-09 13:50 ` Peter Griffin
2026-07-10 9:55 ` Alim Akhtar
2026-07-10 10:00 ` Krzysztof Kozlowski [this message]
2026-07-10 10:08 ` Peter Griffin
2026-07-10 10:20 ` Alim Akhtar
2026-07-10 10:24 ` Krzysztof Kozlowski
2026-07-10 11:37 ` Alim Akhtar
2026-06-27 17:12 ` [PATCH v3 6/6] MAINTAINERS: Add entry for Samsung Exynos8855 SoC Alim Akhtar
2026-07-09 13:50 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eb6b0ef-cbc1-4b2f-b607-986f28ec46ee@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hajun.sung@samsung.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox