From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6548D378D68 for ; Mon, 4 May 2026 09:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777886723; cv=none; b=SzHxEfR6+Wb1U4+g7NQy2AEuqhlB5bfa2NSk9iZQT4mV6/fnXRhvrwooBajwmtDmtMX/rluyhv/UG6+GokBY5nZLm7QNyJkQP22uut6dKqx0pav3F7XOolnC8PmV5C9m1SLSGwXQuCuizAQzCoCher1Yf+IiEHLDVrzvOt/eswM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777886723; c=relaxed/simple; bh=QXh8tpoCgxIgIRivtPfwf9N7Ak8nnu/99/ev/ItSxFE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iYS9sfz4SimQtniGSRqQ1Nl3qcShnLvQjOvgkXZwe5mqSFvZJbGnwI7EDfNmDZEkViNfm7dOzR+kBM/D9Pq/RGva2dgizjuqgm1lmAVFMw3IDJXZBgIuiQ0QHkpaDw1gQ4qB7K8FXirWinK0LWL5FaRzvdjN4ArO7m9Bke5lmpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EwMpDJNv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UGkezyiw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EwMpDJNv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UGkezyiw" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6448fQAD459396 for ; Mon, 4 May 2026 09:25:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NuWaOvztEPnbaaknO2almKhoHkHjQ5+e988XXejF9fM=; b=EwMpDJNvlTRTPpps IIifzaLH68OW/kfIGuOnkK+Z8h1L9O5Vhi4rDnuI65D/Rm+qp3vkgfcQmeZVhyRn Sfp5TK4xJuuVRqTV0RG3GZF/s7Hwoc8tsu8urAry4WhUeNCw3YbsqlocuT9rBG2y BTCvwYJVZx649XHKrsyspuTvJxtvbk/2zNcZNqBQbNN5SFx2ye1J3VaoTMTvmBFl 8vcDKtp/A/vLWR78OKmUwWMadB+q2n/Et8SYl7hk1qx3lWqAMTaanPVCE6ZzDPrz FV61YHeezdriZ+C95NuoD4UcgqtjtEHXm+HhMgiuvthhV056GqHziVVEBbaIFu2u WU8iKQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dwaejn1k4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 04 May 2026 09:25:21 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8aca8a79f42so10217496d6.2 for ; Mon, 04 May 2026 02:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777886721; x=1778491521; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NuWaOvztEPnbaaknO2almKhoHkHjQ5+e988XXejF9fM=; b=UGkezyiw+IKuTroXl7iEqSwzK7shnDHxr0WzYqOTr0t1CsYnnBAUvfaIzRGxopWxMI JRxBmf3eRAWLe4Jonm4EiU/xt4voSIHqflrrgTfWYYu5oGBvL992JUlRslaRH+3oKpOx 9CCBaUqzobv87l/mLV7UCwcWtjxWI8z8YSbv8agEx3ArNsSbX07+JRzHyXT5XBDvYpPI +tKhgk/QbpmHSxxNucQc/jfAZsg9nEcN34udaGFdpuc8WbY6Cy5QJIoj2OyuLiA9pWBZ cECoUFCBnDoep0ZPASdCcNQupjt0EAYXj6Gay060Doy+H1Vvg9M2GA1K58440Kei9vOx tpog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777886721; x=1778491521; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NuWaOvztEPnbaaknO2almKhoHkHjQ5+e988XXejF9fM=; b=pHumk5TpJCk0xnuixhG9eHOX3vBZjgf76lMXU4CB+hQYpP1tFoesHpohycxmLQ0sbH a6hrdavbMjbpStYLCcpXVFmlupcR/rgnJ6fnLNqHTQ6WG5xKF2bRCWBcjn0eizckyLWg RP4qJtIdwSD+NyyGHu1NXYJeeNNEQge0OoxUqjpeErUB9rFTWNPEKf/U7T6/RtaAiOqJ KJzs2TcBcE4Zt01dYpKwaj3mLMDKD1pem3r66W0mbLiO+7i/cw8WjGOQqMxfqR6IVRAm wo38cSvwyXIx+P/YjmhIXG6HFTdC8Z+oOb0mldPGwnQ2NzE7Pyn4esCflKGgwWwuwZ3p mGKQ== X-Forwarded-Encrypted: i=1; AFNElJ/E39rKX5qQMoC6mKFylYI1gqPy2UIWyGt7UJ9mwdwPj5/VX/khl2ni/i57/2scpU/HMCtEieYK6i6WR9A=@vger.kernel.org X-Gm-Message-State: AOJu0YwUJKDhMlDVtwVb4ZCl6msF+M4wqynJU5vkrmhYWDKhZx0wIU2j cBVD8G56hv20oLANAF4Qo9NKvCVEbKIc80F0xjBEysjxSoNvQ4whlpCOdHODmlD7EGjhRSHByG+ 8HbxiGuzpICO+JMt/i1iJaVNkd17a6KjL+zDZH/DLSMF3tAfSzZtGNBAHNt6gyXBLNro= X-Gm-Gg: AeBDievaelrbtqfQh31XxRTe1GV6+wTmV1Cge+04olLFKKcItsG7KLbSkM8rlZa9feg UkREhDDgIdS7VTSZ+Fs9IsNLDHUzSk7AGA2Jqc2TCRUtJbsku5pmbWEoMp1LrjQcPJokHoOZeDs 9yiF7gh50kOEZHrLCUI6pAWuH3rByfVLSnORRvHkBJ4VZWsSyKFZX9EBoMkq2zPI16prUDt6a13 vg55wsWuFpsMdxpre3cmlFvr/Qkzgvc96h+tdA4UW8tUvMtdsEu6cqzLA42IHynzOozFAQMdmns z8Y3TUTorT33DrTLXRaMGixP0d9+M1zt742Sde+UkuRmVfgRS4HnJ3xErngia4zW8B/NTDWxV+v /AX+q0oSCwWLRm9+M8xGvLyl9su2I+XmKrWYYqaSk/3mQf+MAOrUr67Aphn2U8gqVRfOPznnOU3 f0IMgq6DcpflbTOA== X-Received: by 2002:a05:620a:1709:b0:8f1:9e59:2208 with SMTP id af79cd13be357-8fd17d49509mr960458785a.4.1777886720575; Mon, 04 May 2026 02:25:20 -0700 (PDT) X-Received: by 2002:a05:620a:1709:b0:8f1:9e59:2208 with SMTP id af79cd13be357-8fd17d49509mr960456085a.4.1777886720179; Mon, 04 May 2026 02:25:20 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67b85e281cdsm3115053a12.3.2026.05.04.02.25.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 02:25:18 -0700 (PDT) Message-ID: <9eb8e746-5191-40b8-9edd-1286e41cfbae@oss.qualcomm.com> Date: Mon, 4 May 2026 11:25:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: slim7x: Add Embedded Controller node To: Daniel J Blueman , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Randy Dunlap Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Anvesh Jain P , Maya Matuszczyk , Krzysztof Kozlowski , Dmitry Baryshkov , Akhil P Oommen , Abel Vesa , Gaurav Kohli References: <20260502063518.15153-1-daniel@quora.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260502063518.15153-1-daniel@quora.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDA5OSBTYWx0ZWRfX3+LxNBlR3rPl bZNZM9lndVvejOL3hgksquPkw8BRi6i4DTf05hZuD8upJTUX1E/4tOOLkE9CoGb8S52F/GCYVhJ KlN9NtFnoZZ3d9B3g/Ceb630mRjFOOn0ucBJsFcGh7ZNFsDfqFULoohTycYMIRiujP0yEDiuiYJ YVWD+/ntZf7xtV9A69QqkQeS19Zl8yCTfNgbPm0gt0aZ9dHmATit7rztMTWWsY6StR3CnFQaanK x8UanP4aQf1T61wN44GRH6iMyb/WqMZnQ1LmTHtRRFiCIPziLIXMjqCDNjmPUYRYA6mocEM5J1B 5igSCTYd/laRsJomrA1MXuD3E7nUZFYKrbw1n95BuMGHpUD9ufiu+9EApkzDUY5zpaZ4yNyXaVj EBEki7KTanVRjx+bYTzlri4IP1FpAeguokq+ZrSF6aSPQAwYUditzg5cTEu0XD7wfEw1RSAAL42 v7a1uYq6oKZGre6EbHQ== X-Authority-Analysis: v=2.4 cv=Wa48rUhX c=1 sm=1 tr=0 ts=69f86601 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=t9ty7G3lAAAA:8 a=hdOfQ7PHE4ms6XNvABgA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=CsAS6f0m0zARWR-uHzm3:22 X-Proofpoint-ORIG-GUID: fvWsDa4ZWzKDIOX7cVv8WBkv35D3T7xI X-Proofpoint-GUID: fvWsDa4ZWzKDIOX7cVv8WBkv35D3T7xI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_03,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 bulkscore=0 phishscore=0 spamscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040099 On 5/2/26 8:35 AM, Daniel J Blueman wrote: > The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm > Hamoa Customer Reference Device (X1). Wire it up for fan control, > thermal sensor and suspend behaviour. > > Signed-off-by: Daniel J Blueman > --- > Changes in v2: > - corrected DT compatible node You still need to introduce one specific to your actual hardware, even if the driver receives no changes at the moment. This is a measure to enable retroactively enabling quirks for users that update their kernel but not their DTB, so that if a year from now it turns out that the yoga EC requires some special handling (but other users of qcom,hamoa-crd-ec don't), we can easily quirk it out i.e., the desired outcome here is something like: compatible = "lenovo,yoga-slim7x-ec", "qcom,hamoa-crd-ec"; (the first compatible is ignored by the driver matching code today, the other ("fallback") one is matched on) This will need an accompanying change, adding the new Lenovo compatible to the dt-bindings file Konrad