From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246D12DEA74 for ; Tue, 18 Nov 2025 23:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763507557; cv=none; b=qTqqt/JYFphqjvY7m7W2yOyOWhTNSZo/7sRX2lvXvzUNpOSPT+93YT7Mwdbw6uIGKCGbdShKt4mOQWpZqd7KZPZ9ODphIo2PyeA/a1UfgVD9YZvv9rzcH6zvgIPvJKTsQzw0MMsBCcAFeaeE4WtBQYjRpp2dTceSibedIEliBOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763507557; c=relaxed/simple; bh=e/Hnql5X24YAHbZdXDFtkYfQnmz3FhRh0cWocj6LGAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GAIQE65XxO6TFupEQtrB1SjF+iNB3Up65zDKnVI3+tt0CZD485L/9389iBqJJmsZ5NQgu6Rl48TQCFCBCCi+UlfyisarEXEedMXXFwInnf1wuv0CvL/Rn+zZT6XyJibOwWKH62kgWf5lXXsGAARm++F+4p34/BU62kHLSenJ1wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=No7V5DrD; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="No7V5DrD" Message-ID: <9ed9de08-9a5b-4fc9-9213-ca918dafea0b@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1763507542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xaoTNRkEc4AwUxJW2GrHJgy21+EkedavIk+JMyDtFX0=; b=No7V5DrDej+c5MpOesXj0Sy7BeZ+JSAWRkE392Kxi6iS6pIqF3qnFkLFcpmTwS3NbuSAVa BQxNZeLLyguQ7j1Bv3FXE8gK3DnDjrf9T5htpKXVcSD1dYYhETPU/qEBRqeq5ktpfDtsYN TtcmiiQAPV9YPxKM8Eod1rE0U1kPFKc= Date: Tue, 18 Nov 2025 15:12:13 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [bpf-next v1 1/5] selftests/bpf: use sockaddr_storage instead of addr_port in cls_redirect test To: Hoyeon Lee Cc: Andrii Nakryiko , Eduard Zingerman , Alexei Starovoitov , Daniel Borkmann , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20251115225550.1086693-1-hoyeon.lee@suse.com> <20251115225550.1086693-2-hoyeon.lee@suse.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20251115225550.1086693-2-hoyeon.lee@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 11/15/25 2:55 PM, Hoyeon Lee wrote: > struct tuple { > int family; The "family" is not needed either. Just use the ss_family from src or dst. The 'struct tuple' can be removed also? I'm on the fence about whether this "struct sockaddr_storage" change is worth the code churn. Are patch 1 and 2 the only tests that need this change? Patch 3 and 4 make sense. Patch 3 and 4 are applied. Please post patch 5 as a separate patch on its own. > - struct addr_port src; > - struct addr_port dst; > + struct sockaddr_storage src; > + struct sockaddr_storage dst; > };