From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92F1C4167D for ; Thu, 2 Nov 2023 12:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230008AbjKBMHE (ORCPT ); Thu, 2 Nov 2023 08:07:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235599AbjKBMGl (ORCPT ); Thu, 2 Nov 2023 08:06:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 04854112; Thu, 2 Nov 2023 05:04:46 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6C8B2F4; Thu, 2 Nov 2023 05:05:27 -0700 (PDT) Received: from [10.1.33.173] (XHFQ2J9959.cambridge.arm.com [10.1.33.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A1A93F67D; Thu, 2 Nov 2023 05:04:41 -0700 (PDT) Message-ID: <9edbf5f2-efce-40f1-ae7c-34607d9700ce@arm.com> Date: Thu, 2 Nov 2023 12:04:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v33 6/6] selftests: mm: add pagemap ioctl tests Content-Language: en-GB To: Muhammad Usama Anjum , Peter Xu , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman Cc: Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, Cyrill Gorcunov , Mike Rapoport , Nadav Amit , David Hildenbrand References: <20230821141518.870589-1-usama.anjum@collabora.com> <20230821141518.870589-7-usama.anjum@collabora.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2023 11:49, Muhammad Usama Anjum wrote: > On 11/2/23 4:45 PM, Ryan Roberts wrote: >> On 21/08/2023 15:15, Muhammad Usama Anjum wrote: >> >> [...] >> >>> + >>> + >>> +int init_uffd(void) >>> +{ >>> + struct uffdio_api uffdio_api; >>> + >>> + uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY); >>> + if (uffd == -1) >>> + ksft_exit_fail_msg("uffd syscall failed\n"); >>> + >>> + uffdio_api.api = UFFD_API; >>> + uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC | >>> + UFFD_FEATURE_WP_HUGETLBFS_SHMEM; >>> + if (ioctl(uffd, UFFDIO_API, &uffdio_api)) >>> + ksft_exit_fail_msg("UFFDIO_API\n"); >>> + >>> + if (!(uffdio_api.api & UFFDIO_REGISTER_MODE_WP) || >>> + !(uffdio_api.features & UFFD_FEATURE_WP_UNPOPULATED) || >>> + !(uffdio_api.features & UFFD_FEATURE_WP_ASYNC) || >>> + !(uffdio_api.features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM)) >>> + ksft_exit_fail_msg("UFFDIO_API error %llu\n", uffdio_api.api); >> >> Hi, >> >> I've just noticed that this fails on arm64 because the required features are not >> available. It's common practice to skip instead of fail for this sort of >> condition (and that's how all the other uffd tests work). The current fail >> approach creates noise in our CI. >> >> I see this is already in mm-stable so perhaps we can add a patch to fix on top? > Yeah, we can add a patch to skip all the tests instead of failing here. Let > me send a patch this week. Thats great - thanks for the fast response! > >> >> Thanks, >> Ryan >> >> >