From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6513B22A4DB for ; Sun, 5 Oct 2025 23:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759706722; cv=none; b=SGAGynId9YH9y/26avOEnIzlRx5NVqnPvCBebjUSMVZu6poIgXFFeJyXXxYEMdtAzxvqze7zP181RnelGLnZ/EL67/I3qFsU+eLBZQ8mCHUPhMj6xJjOxhAeTkfygi8MqbuHQ6B0XSe5mAY5WSnJsxJmnXKCWWoKumy56DwiFx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759706722; c=relaxed/simple; bh=nq24OG00nbd2TINXwilaodUVdAgf+dAFMRkKWUpwtuw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HKmW7GYehgL59pn+wqcmTCb/IAO6dHLNTp+lfShJOX0DZUETwv/SzxX/D7+1lUHB3sgJ9en8EAky1J4JJizqlXXBjY2rw1LOE2ICL++JBalImlbkstyyZpxslx3JvNgZTOsEzxhyvPk8dOmGStK46e4sbCA5Pvkho2YkwpaNwrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dDz10yre; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dDz10yre" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-b523fb676efso3698409a12.3 for ; Sun, 05 Oct 2025 16:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759706721; x=1760311521; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yYv7vpVBKthNnff+UlSd90a9wZD1vAq0DYVBuSy3Ej4=; b=dDz10yreinvjfIWuZWLXoS8YW1dD6uMP3qcutBaqUp6zY/2bw9G++WugdlvyxqLIGz fKJNgNQKHJ22UYwCsguXL3ZZq24WYSBwMd0Zx2CHsCn7qZKilT8OImiW20/r02AOLHcG RhFe7mdAA20bo6fCL5vn/sqfgbptnplMUDaN9fe+FlXn2ZkpouICPEwYWCdn138p2Q9S jhoyxKWIABMbkrBOwYrYQ6AQONs/M0JrZ6dZqGIVqhMEMIF7Rcw78s+ENF4zSlJYDxjH OCjNdmtU7Cw1L6kn5D5FI+A32K/CE60NWm/y1KevfihWjR7hhO33W3S1CRYedgMXqRfY DExQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759706721; x=1760311521; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yYv7vpVBKthNnff+UlSd90a9wZD1vAq0DYVBuSy3Ej4=; b=bIMJihuzRNc/47rO6p/E/cy0XexNJxKgzGdGfFfgVZMdulcndcppCxD543o2actNOj 8df9aSODgM7dVWl4cFopX8hTWt17oDLFY2WKfBzye4TELGdKB35kp+3kE0D39Hd0/P46 HYmAArPB90Ok5wW6b+9x74/IJfpKA7f5poD0Q3DPi9UlpxEezUGxoMGe33qIFedaKN/q 2ex6AXkfUhuMwIT12kSTOSuegYXttfZ6VCHpu7r/ciVAKcVRBbdJoDVirI+MBqCCPuMQ IOeEJgDox0VAe94Um4W1ODcD3C+HvHU2R4VrfHCb5cez3ms708cjjvrFC7BKvbyn5MD6 VdnQ== X-Forwarded-Encrypted: i=1; AJvYcCXq8j4sFQnj0DkocdMlWQPvG6FI7+DCdJ/Qs3yF8OTdxB+Vygx+3p9+iDL/p8Di3arwgSVGQjApIyFsLrE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+ifdebCZt1S+18n+PFW1PyU9gEsnD4pUcRayKH5XsYc0of3Kf y+q4xTKQy5XQAr/1w5PQ3nJSfcPNX+sYbbuCrcC5UlrPSqm5x98qZ7FJ X-Gm-Gg: ASbGncsumqgbKnViLRI0idCBJgPAOQkXIYb918egjTMOLbFO1WFZWIrmSHSG6sC7ACS Cu4WcDqJD8sr0wcT8ClqHdJGFVpMtvqEzttFMU49W5mOgNqhSGpD1DuLegzgwFchGrEJoA7boG4 zXgTAWj5gQCim4sOboe8Ar0rVg8MRxnXAESwvhTgEEJli8kAHpc4D1I7MZ4m3y9HH/Uqm+Dx8fd +hMXtmN+eZ8ECFvpKBuCImFhr9/NOeLKLbspPAXaHMT5RN/E5bYUF+gjVGysllEbpYjWrKC2xUq fDDTjyZb3ZrFqNgDzqtYUZo0E/OdxjDmsxIaq4u9NqeuGpSbmfOINchr/lP8IrvnpwDALpuH7Mw PUFtNSr4kYNm0UZfQCI/UMyZ66+wwb9PlVWkcJP3kqHuGFQ1D/FppTznCw/d0n7jAaI7IBUsZwI gfBvVGkOKjgFfT2IQZQBI9CpHmLQ== X-Google-Smtp-Source: AGHT+IFzFKXXmzM6dN5RZJw7Ftapo+Zr47psegQMmyZHZB026uVazIjrxM7ymwGOI3B4kPadLZCnrQ== X-Received: by 2002:a17:903:1210:b0:266:64b7:6e38 with SMTP id d9443c01a7336-28e9a6dc994mr115732895ad.46.1759706720577; Sun, 05 Oct 2025 16:25:20 -0700 (PDT) Received: from ?IPV6:2804:7f5:b08b:8d8b:4efe:bacf:243c:8ba8? ([2804:7f5:b08b:8d8b:4efe:bacf:243c:8ba8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-28e8d1d95a0sm113075095ad.115.2025.10.05.16.25.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Oct 2025 16:25:20 -0700 (PDT) Message-ID: <9ee20209-efba-44b1-9902-5885bacfb290@gmail.com> Date: Sun, 5 Oct 2025 20:25:12 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 2/3] iio: adc: max14001: New driver To: David Lechner Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kim Seer Paller , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcelo Schmitt , Marcelo Schmitt , Ceclan Dumitru , Jonathan Santos , Dragos Bogdan References: <961e5351afa408e69541b60ec75852fbbd1ddd24.1759121938.git.marilene.agarcia@gmail.com> <476b75cff0c3e5ff23ba7c642924511f3ba09a3f.1759121938.git.marilene.agarcia@gmail.com> Content-Language: en-US From: Marilene Andrade Garcia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/10/2025 11:03, David Lechner wrote: > On Mon, Sep 29, 2025 at 7:59 AM Marilene Andrade Garcia > wrote: >> > ... >> +static int max14001_read_raw(struct iio_dev *indio_dev, >> + struct iio_chan_spec const *chan, >> + int *val, int *val2, long mask) >> +{ >> + struct max14001_state *st = iio_priv(indio_dev); >> + int ret; >> + >> + switch (mask) { >> + case IIO_CHAN_INFO_RAW: >> + ret = regmap_read(st->regmap, MAX14001_REG_ADC, val); >> + if (ret) >> + return ret; >> + >> + return IIO_VAL_INT; >> + case IIO_CHAN_INFO_AVERAGE_RAW: >> + ret = regmap_read(st->regmap, MAX14001_REG_FADC, val); > > I don't remember... did you give a reason why this should not be a > separate channel? Or just use REG_FADC as the raw value and forget > about REG_ADC? In any case we would want another attribute to control > the filter window size. ... Hello David, Thank you for the review and suggestions. Sorry for not adding any comments about that in v12. From what I understood from our previous conversation, for now the code could have one channel to keep things simple, since we’re not sure if anyone will actually need to read both the filtered and unfiltered data at the same time. I was thinking of sending a separate set of commits to address that after this one gets merged, as it will involve new code changes related to adding a function to configure how many ADC readings are included in the mean calculation, and adding a new attribute to sysfs. Since both IIO_CHAN_INFO_RAW and IIO_CHAN_INFO_AVERAGE_RAW are currently returning the same value, I could drop IIO_CHAN_INFO_AVERAGE_RAW in v13 and add it back in the next series of commits to implement the related feature. I would like to know your thoughts about it, because if you prefer, I could change my plans and implement it in v13. Best Regards, Marilene