Re: [PATCH V8 05/44] x86/fpu: Refactor arch_set_user_pkey_access()

Ira Weiny
2022-02-02T20:22:59Z

On Fri, Jan 28, 2022 at 02:50:44PM -0800, Dave Hansen wrote:
> On 1/27/22 09:54, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > Both PKU and PKS update their register values in the same way. They can
> > therefore share the update code.
> >
> > Define a helper, pkey_update_pkval(), which will be used to support both
> > Protection Key User (PKU) and the new Protection Key for Supervisor
> > (PKS) in subsequent patches.
> >
> > pkey_update_pkval() contributed by Thomas
> >
> > Co-developed-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>
> Looks better than my original code. Waaaaaay simpler.
>
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>

Thanks,
Ira