From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D2742DFFF for ; Fri, 15 May 2026 09:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836667; cv=none; b=aNnEBHEntcIx59nQZeldKLufimlgajKqCWYVRntpGzp8M7Jjxm0h/nKyhXZmgA55RZACs5tfwpwgOBc/FOzSAlTUa4pszkC+b7pJzwdSa0+caxg3/x+JIgo6WjpT3uKvE1nwK/HeUNWD9ODKYQRzmecGckcM1uwabwHtgT+g8v8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836667; c=relaxed/simple; bh=JZTw67nNsqgHy2aR+AH+SpVsT+MYJ6AXI/iUpn9bhsA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=g6aT3LBK07fQHWpyVX7Y0T9m4fHcF8vldCdqNtzB90PhO/mthecEYZVXm0ZHr/6vPv5DBO5HG9Q/T8trBDczGuWE5LcyFOeVEUlixyx6G/y+l+a1raHqttMFFkC4BN4VAZjoMVvHmheHN2XlCRpeotmEhhECGmEyv83ZhnNXGNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xx11sRa2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U+B7j853; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xx11sRa2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U+B7j853" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F98Vt21715409 for ; Fri, 15 May 2026 09:17:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RPVEd5Ws7PMkL2UvTGYvywwSu1vfE9SuAGTbdEXzWeU=; b=Xx11sRa2zySAoaeZ JJD1orXvUJtsm9aX2C2iOtVJR7W3tbxneykSHzsu8qXpFY+YX3JNKpwchA4f7sU+ +MH7Jc+J5+G2WbnFUoFUayxQD5movL2Z4PnOvwUkLKsg+VU7PN3lf3jDABMsBdqk bAyDf6cUr16Z8UtG95LDY9ME+YCKJJIK0k5H4IqgqARX8F9t/MYRzD8GLNz4MgEs ysYwBsAHtqfHZza7mhpIKXWwfXNwoAWI87w5C2oDugX1cFr2XV3wpPlrFzh2y6EO HSE6WomD2795xwg6FStTU0pLFqTp4IAF+9O1bGwIf1cFlP7dbk6wz+aSjMDj0OUs kxrbUw== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5tyxsbwd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 09:17:45 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5756f9292c5so214732e0c.0 for ; Fri, 15 May 2026 02:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778836664; x=1779441464; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=RPVEd5Ws7PMkL2UvTGYvywwSu1vfE9SuAGTbdEXzWeU=; b=U+B7j853M9EaXdq33jX2shedWvuy4xeIWPMiQhUZW/alLKhF6bBsSeUkQjKP/wijX9 dD8bwIiRkv2SEwXEtFZYHMkslFihOVOUSqLzM4z+mpwqC8QqkPu4Xpu1LjqMvg8mc6Xq PfS6CCQGOIeZ61Z2T9Ggw8tMxKWzX+s3pyM1kubDiWcLlvaIx1aIT76xxe+41XgGYTOC 3WFwkvYCeqvsDCoFqHODakQq7G/c9qE3K8gFNUuc9mvobTqrfgQsQWv//SfjWxKx0cA0 uNXl0sUPcyq2miQBsyiW//ny9biuUWTnm8QxCveD/MLQ4XAuLDxqTrpiNr2m+EMiUfij WypA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778836664; x=1779441464; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RPVEd5Ws7PMkL2UvTGYvywwSu1vfE9SuAGTbdEXzWeU=; b=DRDhuIzQw/WuVEkwEj7gzGwiufbAnVi++JVo2pF1E81Lq5vuw3LiKYtRg4kK018SzZ NaXiXayrQbDDY3jU/A5J52FLA2Djft0iFF9stbyReEtvaPHO8sLh4Mr76GE10AMFSI0J 2bMv9FVMKZ9eE1IgsHhkRktnbLktPEjlcOXei+s6Dcgxpp/pWjULY6khcwtOvIQOzoK0 PnGg6NTc8+MqWfpHd23swS6tvirJjXn014wL3WawSjOSblI2mfGoSt7DbRv+08OhJLxN 2mQM8h/7pmJgM6/QVdmHNp0Uqf+jXwn2KoT/kEhyJtyv4cDzKHWTfWtx4ApNopQ6Gu0a Ruvg== X-Forwarded-Encrypted: i=1; AFNElJ+I6w0kHrrwEKnFnPt0vvXCnNivwMWc2JDkm7gYTaRSozi/pZw/yz2F7Ts4oaq3aippHO9Q/B7pO7pPIXs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7/lXnf4oCiMCKu2Ooag5E2LTHr1y+iIwK4HXLVGXtEVJPU1h7 lJH4JjjT+hKe0wjg09YcPDuZmduOb8LKErbKDPuOv6jcSi7Yg1rx5CekcR2hvIMbHvGIrkphX4A iTPBZWPkVKc5SFBQUPCCGw27eJG6g71vdw2GJM6lkDI3ejlCBasoZrw23jTS6BAdi2Vs= X-Gm-Gg: Acq92OFWAZCnTu1nfh/dexRXzCpzave3YTYy7i/THmpZKYbNDiQwg5lYO0o+0EJ9L8d yrUc6q6hKXS0dHvjFgRqHrSo1p60uL+5TTE82gU1S1S0UO4QrclqWKwyDKRTKtHsSojQ2o+ufEf zCiYoUoufrn/KH739kzuZEUrkmcCasZ8L1rReryi9k/BreNrpUavdaK+zZGvVXtiqnuvf/J8DYG LYFkWnX63oa3GTM1NOWpFiuHEJS61ZR0gGURlQQdRBJVKNwu03CraLxFompQIDhRu3o955WCnph fugApvohO6nOh9n9v8MKsyj5t+xytWCjtbiVM82XPcdaIcoLUSTOwQsZs9mfnNlYzxDdIIhkB+M bJDR/HTfoMXjc77n6IrNqoj8qSiheP2YuZGoI76pgIUGRXEzO X-Received: by 2002:a05:6102:4a8b:b0:631:26f6:701c with SMTP id ada2fe7eead31-63a408b9ac1mr1501097137.31.1778836664102; Fri, 15 May 2026 02:17:44 -0700 (PDT) X-Received: by 2002:a05:6102:4a8b:b0:631:26f6:701c with SMTP id ada2fe7eead31-63a408b9ac1mr1501086137.31.1778836663684; Fri, 15 May 2026 02:17:43 -0700 (PDT) Received: from [192.168.68.112] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-bd4f4e21b1esm197389266b.44.2026.05.15.02.17.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 02:17:42 -0700 (PDT) Message-ID: <9efb40d3-cfc4-4db0-9568-058e51292a40@oss.qualcomm.com> Date: Fri, 15 May 2026 09:17:41 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: ASoC q6asm race condition when stopping and preparing the stream To: Richard Acayan , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Greg Kroah-Hartman , Kees Cook , Joris Verhaegen , Kuninori Morimoto , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dMWWXuZb c=1 sm=1 tr=0 ts=6a06e4b9 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=TA6Hy007wzxYe2ctAm0A:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-ORIG-GUID: Ra1xN1kc0WQ5ztv0js32D-ZPYRl41qFe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDA5MyBTYWx0ZWRfX1PGOlPNqwV9v MW7R+GjkgFp5nuiY3BBRLExRkh5ae/78rdu4emvoNMwLfd7UYsvK430gxAZCAPhblZFipd7Rck+ lHNR+Nzj1sYDj2vCgn+Dljc1BjzGd6JVZgO7qWid0AHLepFoa+4Jue3fPAQ+zSKcMZc1k3pPDGX 6RwDgpMYNTJ6OG1NWmXSROu1fbzdRGHTL/T7VTRfNm/S1BpkWMa5m+o56VO+eGvKYIQ1gcpDMWz A63pokISIwPzw1yys/gB4vwTB1jLuRkMwtXWZvmNPZbQVByT7clzRCBKth5ViWrwRkqiKO6dTee sUoG4G+9mCysE6b9Wsu8FMzMx33NPxvb6HY2nS0VX0UMSV53YnZZ8qK/mUks72ZdFDtipIGShtv oPRI/Xcdxxf6SV2N0JCN88TxbuHnjed2+DnreMBGCc0a0/cTxhhesaE3ftLPWMZHUqkxM53vsb/ l1zg2w2v7QvjuBIkmyg== X-Proofpoint-GUID: Ra1xN1kc0WQ5ztv0js32D-ZPYRl41qFe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150093 On 5/1/26 2:41 PM, Richard Acayan wrote: > Hi, > > There seems to be a race condition in q6asm when stopping the stream > (with uncompressed PCM). When receiving SNDRV_PCM_TRIGGER_STOP, the > driver sets the state to Q6ASM_STREAM_STOPPED and sends CMD_EOS to the > ADSP. If userspace decides to prepare the stream again in > q6asm_dai_prepare before receiving ASM_CLIENT_EVENT_CMD_EOS_DONE, the > memory-mapped region appears to still be in use and fails to map again. > > I believe this race was observed since commit 81c53b52de21 ("ASoC: qcom: > qdsp6: q6asm-dai: set 10 ms period and buffer alignment."), but would > need to verify. On sdm670, we are coping downstream by keeping the state > as Q6ASM_STREAM_RUNNING until receiving CMD_EOS_DONE. Can you please share the full kernel log. --srini > > Can the ADSP emit DATA_WRITE_DONE or DATA_READ_DONE before CMD_EOS_DONE? > We might need an extra stopping state between CMD_EOS and CMD_EOS_DONE > so the driver doesn't request more data transfers.