From: Junxiao Bi <junxiao.bi@oracle.com>
To: Hillf Danton <hdanton@sina.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@kernel.dk
Subject: Re: [PATCH] block: fix io hung by block throttle
Date: Mon, 19 Apr 2021 09:39:30 -0700 [thread overview]
Message-ID: <9f02eb4d-4832-9f84-9df9-364f2000dd29@oracle.com> (raw)
In-Reply-To: <1c3a2874-35bd-3ff0-3088-1a6ea968d016@oracle.com>
On 4/18/21 11:09 PM, Junxiao Bi wrote:
>> - finish_wait(&rqw->wait, &data.wq);
>> + mutex_lock(&rqw->throttle_mutex);
>> + wait_event(rqw->wait, acquire_inflight_cb(rqw, private_data));
>> + mutex_unlock(&rqw->throttle_mutex);
>
> This will break the throttle? There is a inflight io limitation. With
> this change, there can be only one io inflight whatever the limit is.
Sorry, ignore this. I should go sleep that time.
>
> Thanks,
>
> Junxiao.
next prev parent reply other threads:[~2021-04-19 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 21:18 [PATCH] block: fix io hung by block throttle Junxiao Bi
[not found] ` <20210415041153.577-1-hdanton@sina.com>
2021-04-15 5:01 ` Junxiao Bi
2021-04-21 21:28 ` Junxiao Bi
[not found] ` <20210417101008.4132-1-hdanton@sina.com>
2021-04-17 21:37 ` Junxiao Bi
[not found] ` <20210418123342.13740-1-hdanton@sina.com>
2021-04-19 6:09 ` Junxiao Bi
2021-04-19 16:39 ` Junxiao Bi [this message]
2021-04-23 2:55 ` [block] 658f2fb7d2: fxmark.hdd_f2fs_dbench_client_72_directio.works/sec -21.4% regression kernel test robot
2021-04-23 5:26 ` Junxiao Bi
2021-04-28 21:08 ` Junxiao Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f02eb4d-4832-9f84-9df9-364f2000dd29@oracle.com \
--to=junxiao.bi@oracle.com \
--cc=axboe@kernel.dk \
--cc=hdanton@sina.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox