From: Martin KaFai Lau <martin.lau@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, haoluo@google.com,
john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
linux-kernel@vger.kernel.org, sdf@google.com, song@kernel.org,
syzkaller-bugs@googlegroups.com, yhs@fb.com,
syzbot <syzbot+ebe648a84e8784763f82@syzkaller.appspotmail.com>
Subject: Re: [syzbot] [bpf?] KCSAN: data-race in __bpf_lru_list_rotate / __htab_lru_percpu_map_update_elem (5)
Date: Tue, 25 Apr 2023 09:21:08 -0700 [thread overview]
Message-ID: <9f190e7d-81f8-6a19-2c40-efff3840a606@linux.dev> (raw)
In-Reply-To: <CAADnVQK3m34RPCgw-7qWxE4gBb+ZoX4ZmEtbe-Ku0_ZOSG+5vA@mail.gmail.com>
On 4/25/23 8:08 AM, Alexei Starovoitov wrote:
> Martin,
>
>
> Please take a look at the trace below.
> I think we just need to annotate bpf_lru_node_set_ref() with data_race().
> wdyt?
Agreed. node->ref needs a data_race(). I will post a patch.
prev parent reply other threads:[~2023-04-25 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 7:31 [syzbot] [bpf?] KCSAN: data-race in __bpf_lru_list_rotate / __htab_lru_percpu_map_update_elem (5) syzbot
2023-04-25 15:08 ` Alexei Starovoitov
2023-04-25 16:21 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f190e7d-81f8-6a19-2c40-efff3840a606@linux.dev \
--to=martin.lau@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=syzbot+ebe648a84e8784763f82@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox