From: Luis de Bethencourt <luisbg@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Joe Perches <joe@perches.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH] ALSA: pcm: Fix trailing semicolon
Date: Tue, 16 Jan 2018 13:28:32 +0000 [thread overview]
Message-ID: <9f26c3ec-75fe-2dce-05ee-a26fea0bcfd6@kernel.org> (raw)
In-Reply-To: <s5hk1wjc4mk.wl-tiwai@suse.de>
On 01/15/2018 07:18 PM, Takashi Iwai wrote:
> On Mon, 15 Jan 2018 19:18:57 +0100,
> Luis de Bethencourt wrote:
>>
>> From: Ubuntu <luisbg@kernel.org>
>
> Is this from address intentional? It'd be taken as is via git-am.
>
>
> thanks,
>
> Takashi
>
>> The trailing semicolon is an empty statement that does no operation.
>> Removing it since it doesn't do anything.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
>> ---
>>
>>
>> Hi,
>>
>> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
>> suggested I fix it treewide [0].
>>
>> Best regards
>> Luis
>>
>>
>> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
>> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>>
>> sound/core/pcm_native.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
>> index 3f13e8da0812..51104df924e1 100644
>> --- a/sound/core/pcm_native.c
>> +++ b/sound/core/pcm_native.c
>> @@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
>> int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
>> struct vm_area_struct *area)
>> {
>> - struct snd_pcm_runtime *runtime = substream->runtime;;
>> + struct snd_pcm_runtime *runtime = substream->runtime;
>>
>> area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
>> return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
>> --
>> 2.15.1
>>
>>
Hi Takashi,
Sorry. Not sure how git send-email added that line to the commit message.
I have sent a v2 correcting it.
Thanks,
Luis
prev parent reply other threads:[~2018-01-16 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 18:18 [PATCH] ALSA: pcm: Fix trailing semicolon Luis de Bethencourt
2018-01-15 19:18 ` Takashi Iwai
2018-01-16 13:28 ` Luis de Bethencourt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f26c3ec-75fe-2dce-05ee-a26fea0bcfd6@kernel.org \
--to=luisbg@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox