Re: [PATCH] net #9

Pavel Machek
2001-05-31T19:45:20Z

Hi!

> > This is standard kernel cleanup that makes the resulting image smaller.
> > These patches have been going into all areas of the kernel for quite
> > some time.
>
> This doesn't make it right.

Well... It does. Code should be uniform. You may like

if (
x == y
) {
printf(
"ahoj"
);
}

style of indentation, but it is not okay in kernel.

> Ok, while we are on the topic : could somebody explain me why
> we can't get gcc to do that for us ? What is preventing adding a gcc

int xyzzy;

goes to BSS, while

int xyzzy = 0

goes to DATA. That is important for some folks.

> command line flag to do exactly that ? It's not like rocket science
> (simple test) and would avoid to have tediously to go through all

It is actually not *so* easy to do it in gcc; there's patch, however.

Pavel
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org