Re: [PATCH v4 1/3] dt-bindings: iio: adf4371: add refin mode

Jonathan Cameron
2025-01-12T15:01:56Z

On Thu, 9 Jan 2025 15:37:05 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Add support for selecting between single-ended and differential
> reference input.
>
> By default the single-ended input is enabled.
>
> Input frequency boundaries are change based on the mode selected
> (single-ended/differential).
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v4:
> - add enum in clock-names to support both se and diff input.
> .../devicetree/bindings/iio/frequency/adf4371.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> index 1cb2adaf66f9..9ad5b22c59d7 100644
> --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> @@ -30,8 +30,11 @@ properties:
>
> clock-names:
> description:
> - Must be "clkin"
> - maxItems: 1
> + Must be "clkin" if the input reference is single ended or "clkin-diff"
> + if the input reference is differential. By default single ended input is
> + applied.
> + enum: [clkin, clkin-diff]
> + default: clkin
Given the property is required, what does a default mean?

I don't think you want to apply a default, or mention it in the description.
Otherwise LGTM.

>
> adi,mute-till-lock-en:
> type: boolean