From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] serial: 8250_pci: Replace dev_*() by pci_*() macros
Date: Tue, 26 Oct 2021 07:20:45 +0200 [thread overview]
Message-ID: <9f7e1a82-7afc-b4e6-77b8-699607d5c994@kernel.org> (raw)
In-Reply-To: <20211022135147.70965-3-andriy.shevchenko@linux.intel.com>
On 22. 10. 21, 15:51, Andy Shevchenko wrote:
> PCI subsystem provides convenient shortcut macros for message printing.
> Use those macros instead of dev_*().
Hopefully they are preferred by the PCI maintainer too :)...
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jiri Slaby <jslaby@kernel.org>
> ---
> v2: dropped unrelated change (Joe)
> drivers/tty/serial/8250/8250_pci.c | 52 +++++++++++++-----------------
> 1 file changed, 22 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 463b2c71da6f..aea12263a1ff 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -75,13 +75,12 @@ static int pci_default_setup(struct serial_private*,
>
> static void moan_device(const char *str, struct pci_dev *dev)
> {
> - dev_err(&dev->dev,
> - "%s: %s\n"
> + pci_err(dev, "%s\n"
> "Please send the output of lspci -vv, this\n"
> "message (0x%04x,0x%04x,0x%04x,0x%04x), the\n"
> "manufacturer and name of serial board or\n"
> "modem board to <linux-serial@vger.kernel.org>.\n",
> - pci_name(dev), str, dev->vendor, dev->device,
> + str, dev->vendor, dev->device,
> dev->subsystem_vendor, dev->subsystem_device);
> }
>
...
--
js
suse labs
next prev parent reply other threads:[~2021-10-26 5:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 13:51 [PATCH v2 1/3] serial: 8250_pci: Refactor the loop in pci_ite887x_init() Andy Shevchenko
2021-10-22 13:51 ` [PATCH v2 2/3] serial: 8250_pci: Get rid of redundant 'else' keyword Andy Shevchenko
2021-10-26 5:21 ` Jiri Slaby
2021-10-22 13:51 ` [PATCH v2 3/3] serial: 8250_pci: Replace dev_*() by pci_*() macros Andy Shevchenko
2021-10-26 5:20 ` Jiri Slaby [this message]
2021-10-26 5:26 ` [PATCH v2 1/3] serial: 8250_pci: Refactor the loop in pci_ite887x_init() Jiri Slaby
2021-10-26 6:44 ` Greg Kroah-Hartman
2021-10-26 6:51 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f7e1a82-7afc-b4e6-77b8-699607d5c994@kernel.org \
--to=jirislaby@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox