From: Samuel Ortiz <sameo@openedhand.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH] mfd: Don't use NO_IRQ in WM8350
Date: Wed, 15 Oct 2008 07:55:17 -0400 [thread overview]
Message-ID: <9fb8beea82becda1567755f13aab4c11@localhost> (raw)
In-Reply-To: <1224066054-24401-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Wed, 15 Oct 2008 11:20:54 +0100, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> NO_IRQ is only defined on some architectures - the general way to test
> for an invalid IRQ in the modern kernel is by comparing with zero.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied, thanks.
I'll send a pull request to Linus soon.
Cheers,
Samuel.
> ---
>
> This is a build fix for platforms that don't define NO_IRQ (which is
> most of them). Please merge as soon as possible.
>
> drivers/mfd/wm8350-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index 25a7a5d..bf87f67 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -1217,7 +1217,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int
> irq,
>
> mutex_init(&wm8350->irq_mutex);
> INIT_WORK(&wm8350->irq_work, wm8350_irq_worker);
> - if (irq != NO_IRQ) {
> + if (irq) {
> ret = request_irq(irq, wm8350_irq, 0,
> "wm8350", wm8350);
> if (ret != 0) {
>
next prev parent reply other threads:[~2008-10-15 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 10:20 [PATCH] mfd: Don't use NO_IRQ in WM8350 Mark Brown
2008-10-15 11:55 ` Samuel Ortiz [this message]
2008-10-15 14:15 ` Mark Brown
2008-10-15 15:33 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb8beea82becda1567755f13aab4c11@localhost \
--to=sameo@openedhand.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox