[PATCH v2 0/4] Update Vgpu minimum voltage for MT8183, MT8186, MT8192, MT8195

[PATCH v2 0/4] Update Vgpu minimum voltage for MT8183, MT8186, MT8192, MT8195

[Pin-yen Lin]

Use the minimum voltage listed on the Vgpu regulator datasheets instead
of the minimum value on GPU OPP table. This is because the requested
voltage could be lower when the MTK Smart Voltage Scaling (SVS) driver
is enabled.

Also update the incorrect MT6315 regulator usages on MT8192 and MT8195.

Changes in v2:
- Update Vgpu min voltage for MT8183, MT8186, MT8195
- Fix other usages of MT6315 buck1/buck3

Pin-yen Lin (4):
  arm64: dts: mediatek: mt8192-asurada: Update min voltage constraint
    for MT6315
  arm64: dts: mediatek: mt8195-cherry: Update min voltage constraint for
    MT6315
  arm64: dts: mediatek: mt8183-kukui: Use default min voltage for MT6358
  arm64: dts: mediatek: mt8186-corsola: Update min voltage constraint
    for Vgpu

 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi   | 1 -
 arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 6 +++---
 arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi  | 4 ++--
 4 files changed, 6 insertions(+), 7 deletions(-)

-- 
2.44.0.291.gc1ea87d7ee-goog

[PATCH v2 1/4] arm64: dts: mediatek: mt8192-asurada: Update min voltage constraint for MT6315

[Pin-yen Lin]

Update the minimum voltage from 300000 uV to 400000 uV so it matches
the MT6315 datasheet.

Also update the minimum voltage for Vgpu regulator from 606250 uV to
400000 uV because the requested voltage could be lower than the minimum
voltage on the GPU OPP table when the MTK Smart Voltage Scaling (SVS)
driver is enabled.

Fixes: 3183cb62b033 ("arm64: dts: mediatek: asurada: Add SPMI regulators")
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---

Changes in v2:
- Change the value to 400000 and update other mt6315 usages

 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
index 43d80334610a..2eafe66fbb8a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
@@ -1421,7 +1421,7 @@ regulators {
 			mt6315_6_vbuck1: vbuck1 {
 				regulator-compatible = "vbuck1";
 				regulator-name = "Vbcpu";
-				regulator-min-microvolt = <300000>;
+				regulator-min-microvolt = <400000>;
 				regulator-max-microvolt = <1193750>;
 				regulator-enable-ramp-delay = <256>;
 				regulator-allowed-modes = <0 1 2>;
@@ -1431,7 +1431,7 @@ mt6315_6_vbuck1: vbuck1 {
 			mt6315_6_vbuck3: vbuck3 {
 				regulator-compatible = "vbuck3";
 				regulator-name = "Vlcpu";
-				regulator-min-microvolt = <300000>;
+				regulator-min-microvolt = <400000>;
 				regulator-max-microvolt = <1193750>;
 				regulator-enable-ramp-delay = <256>;
 				regulator-allowed-modes = <0 1 2>;
@@ -1448,7 +1448,7 @@ regulators {
 			mt6315_7_vbuck1: vbuck1 {
 				regulator-compatible = "vbuck1";
 				regulator-name = "Vgpu";
-				regulator-min-microvolt = <606250>;
+				regulator-min-microvolt = <400000>;
 				regulator-max-microvolt = <800000>;
 				regulator-enable-ramp-delay = <256>;
 				regulator-allowed-modes = <0 1 2>;
-- 
2.44.0.291.gc1ea87d7ee-goog

[PATCH v2 2/4] arm64: dts: mediatek: mt8195-cherry: Update min voltage constraint for MT6315

[Pin-yen Lin]

Update the minimum voltage from 300000 uV to 400000 uV so it matches
the MT6315 datasheet.

Also update the minimum voltage for Vgpu regulator from 625000 uV to
400000 uV because the requested voltage could be lower than the minimum
voltage on the GPU OPP table when the MTK Smart Voltage Scaling (SVS)
driver is enabled.

Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---

Changes in v2:
- New in v2

 arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index f94c07f8b933..c0223f84b45b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -1214,7 +1214,7 @@ regulators {
 			mt6315_6_vbuck1: vbuck1 {
 				regulator-compatible = "vbuck1";
 				regulator-name = "Vbcpu";
-				regulator-min-microvolt = <300000>;
+				regulator-min-microvolt = <400000>;
 				regulator-max-microvolt = <1193750>;
 				regulator-enable-ramp-delay = <256>;
 				regulator-ramp-delay = <6250>;
@@ -1232,7 +1232,7 @@ regulators {
 			mt6315_7_vbuck1: vbuck1 {
 				regulator-compatible = "vbuck1";
 				regulator-name = "Vgpu";
-				regulator-min-microvolt = <625000>;
+				regulator-min-microvolt = <400000>;
 				regulator-max-microvolt = <1193750>;
 				regulator-enable-ramp-delay = <256>;
 				regulator-ramp-delay = <6250>;
-- 
2.44.0.291.gc1ea87d7ee-goog

[PATCH v2 3/4] arm64: dts: mediatek: mt8183-kukui: Use default min voltage for MT6358

[Pin-yen Lin]

The requested voltage could be lower than the minimum voltage on the
GPU OPP table when the MTK Smart Voltage Scaling (SVS) driver is
enabled, so removing the definition in mt8183-kukui to use the default
minimum voltage (500000 uV) defined in mt6358.dtsi.

Fixes: 31c6732da9d5 ("arm64: dts: mediatek: mt8183-kukui: Override vgpu/vsram_gpu constraints")
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---

Changes in v2:
- New in v2

 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 3830daf7ea85..a64d06adf796 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -433,7 +433,6 @@ &mt6358regulator {
 };
 
 &mt6358_vgpu_reg {
-	regulator-min-microvolt = <625000>;
 	regulator-max-microvolt = <900000>;
 
 	regulator-coupled-with = <&mt6358_vsram_gpu_reg>;
-- 
2.44.0.291.gc1ea87d7ee-goog

[PATCH v2 4/4] arm64: dts: mediatek: mt8186-corsola: Update min voltage constraint for Vgpu

[Pin-yen Lin]

The requested voltage could be lower than the minimum voltage on the
GPU OPP table when the MTK Smart Voltage Scaling (SVS) driver is
enabled, so update the minimum voltage constraint from 600000 uV to
500000 uV as listed on the mt6366 datasheet.

Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
Signed-off-by: Pin-yen Lin <treapking@chromium.org>

---

Changes in v2:
- New in v2

 arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
index 3dea28f1d806..1807e9d6cb0e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
@@ -1296,7 +1296,7 @@ mt6366_vgpu_reg: vgpu {
 				 * regulator coupling requirements.
 				 */
 				regulator-name = "ppvar_dvdd_vgpu";
-				regulator-min-microvolt = <600000>;
+				regulator-min-microvolt = <500000>;
 				regulator-max-microvolt = <950000>;
 				regulator-ramp-delay = <6250>;
 				regulator-enable-ramp-delay = <200>;
-- 
2.44.0.291.gc1ea87d7ee-goog

Re: [PATCH v2 4/4] arm64: dts: mediatek: mt8186-corsola: Update min voltage constraint for Vgpu

[AngeloGioacchino Del Regno]

Il 15/03/24 12:16, Pin-yen Lin ha scritto:
> The requested voltage could be lower than the minimum voltage on the
> GPU OPP table when the MTK Smart Voltage Scaling (SVS) driver is
> enabled, so update the minimum voltage constraint from 600000 uV to
> 500000 uV as listed on the mt6366 datasheet.
> 
> Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2 3/4] arm64: dts: mediatek: mt8183-kukui: Use default min voltage for MT6358

[AngeloGioacchino Del Regno]

Il 15/03/24 12:16, Pin-yen Lin ha scritto:
> The requested voltage could be lower than the minimum voltage on the
> GPU OPP table when the MTK Smart Voltage Scaling (SVS) driver is
> enabled, so removing the definition in mt8183-kukui to use the default
> minimum voltage (500000 uV) defined in mt6358.dtsi.
> 
> Fixes: 31c6732da9d5 ("arm64: dts: mediatek: mt8183-kukui: Override vgpu/vsram_gpu constraints")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2 2/4] arm64: dts: mediatek: mt8195-cherry: Update min voltage constraint for MT6315

[AngeloGioacchino Del Regno]

Il 15/03/24 12:16, Pin-yen Lin ha scritto:
> Update the minimum voltage from 300000 uV to 400000 uV so it matches
> the MT6315 datasheet.
> 
> Also update the minimum voltage for Vgpu regulator from 625000 uV to
> 400000 uV because the requested voltage could be lower than the minimum
> voltage on the GPU OPP table when the MTK Smart Voltage Scaling (SVS)
> driver is enabled.
> 
> Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2 1/4] arm64: dts: mediatek: mt8192-asurada: Update min voltage constraint for MT6315

[AngeloGioacchino Del Regno]

Il 15/03/24 12:16, Pin-yen Lin ha scritto:
> Update the minimum voltage from 300000 uV to 400000 uV so it matches
> the MT6315 datasheet.
> 
> Also update the minimum voltage for Vgpu regulator from 606250 uV to
> 400000 uV because the requested voltage could be lower than the minimum
> voltage on the GPU OPP table when the MTK Smart Voltage Scaling (SVS)
> driver is enabled.
> 
> Fixes: 3183cb62b033 ("arm64: dts: mediatek: asurada: Add SPMI regulators")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2 0/4] Update Vgpu minimum voltage for MT8183, MT8186, MT8192, MT8195

[AngeloGioacchino Del Regno]

On Fri, 15 Mar 2024 19:16:01 +0800, Pin-yen Lin wrote:
> Use the minimum voltage listed on the Vgpu regulator datasheets instead
> of the minimum value on GPU OPP table. This is because the requested
> voltage could be lower when the MTK Smart Voltage Scaling (SVS) driver
> is enabled.
> 
> Also update the incorrect MT6315 regulator usages on MT8192 and MT8195.
> 
> [...]

Applied to v6.9-fixes/dts64, thanks!

[1/4] arm64: dts: mediatek: mt8192-asurada: Update min voltage constraint for MT6315
      commit: 374a7c6400e314458178255a63c37d6347845092
[2/4] arm64: dts: mediatek: mt8195-cherry: Update min voltage constraint for MT6315
      commit: e9a6b8b5c61350535c7eb5ea9b2dde0d5745bd1b
[3/4] arm64: dts: mediatek: mt8183-kukui: Use default min voltage for MT6358
      commit: 296118a8dc297de47d9b3a364b9743f8446bd612
[4/4] arm64: dts: mediatek: mt8186-corsola: Update min voltage constraint for Vgpu
      commit: 366940c860bc27cc1cc92061e6626a4fa56bab3c

Cheers,
Angelo