From: Punit Agrawal <punit.agrawal@arm.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH] thermal: Bind cooling devices with the correct arguments
Date: Tue, 17 Jun 2014 11:20:38 +0100 [thread overview]
Message-ID: <9hh61jzsuq1.fsf@arm.com> (raw)
In-Reply-To: <1401789598-14967-1-git-send-email-punit.agrawal@arm.com> (Punit Agrawal's message of "Tue, 3 Jun 2014 10:59:58 +0100")
Ping?
Punit Agrawal <punit.agrawal@arm.com> writes:
> When binding cooling devices to thermal zones created from the device
> tree the minimum and maximum cooling states are in the wrong order
> leading to failure to bind.
>
> Fix the order of cooling states in the call to
> thermal_zone_bind_cooling_device to fix this.
>
> Cc:Zhang Rui <rui.zhang@intel.com>
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> ---
> Hi Eduardo,
>
> I am hoping this can be picked up for 3.16 as a bug fix.
>
> Thanks,
> Punit
>
> drivers/thermal/of-thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 04b1be7..97d312f 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -156,8 +156,8 @@ static int of_thermal_bind(struct thermal_zone_device *thermal,
>
> ret = thermal_zone_bind_cooling_device(thermal,
> tbp->trip_id, cdev,
> - tbp->min,
> - tbp->max);
> + tbp->max,
> + tbp->min);
> if (ret)
> return ret;
> }
next prev parent reply other threads:[~2014-06-17 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 9:59 [PATCH] thermal: Bind cooling devices with the correct arguments Punit Agrawal
2014-06-17 10:20 ` Punit Agrawal [this message]
2014-06-18 22:17 ` Stephen Boyd
2014-06-24 10:43 ` Punit Agrawal
2014-07-02 11:54 ` edubezval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9hh61jzsuq1.fsf@arm.com \
--to=punit.agrawal@arm.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox