From: Punit Agrawal <punit.agrawal@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: Add braces around suspect code
Date: Mon, 30 Jun 2014 16:03:12 +0100 [thread overview]
Message-ID: <9hhionibftb.fsf@arm.com> (raw)
In-Reply-To: <1403134328-4668-1-git-send-email-sboyd@codeaurora.org> (Stephen Boyd's message of "Wed, 18 Jun 2014 16:32:08 -0700")
Stephen Boyd <sboyd@codeaurora.org> writes:
> It looks like this code is missing braces, otherwise the if
> statement shouldn't have been indented. Fix it.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/thermal/of-thermal.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 04b1be7fa018..a95ee2889b19 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -712,11 +712,12 @@ thermal_of_build_thermal_zone(struct device_node *np)
> }
>
> i = 0;
> - for_each_child_of_node(child, gchild)
> + for_each_child_of_node(child, gchild) {
> ret = thermal_of_populate_bind_params(gchild, &tz->tbps[i++],
> tz->trips, tz->ntrips);
> if (ret)
> goto free_tbps;
> + }
>
> finish:
> of_node_put(child);
Looks good to me.
Reviewed-by: Punit Agrawal <punit.agrawal@arm.com>
prev parent reply other threads:[~2014-06-30 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 23:32 [PATCH] thermal: Add braces around suspect code Stephen Boyd
2014-06-30 15:03 ` Punit Agrawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9hhionibftb.fsf@arm.com \
--to=punit.agrawal@arm.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox