Re: ISOFS corrupt filesizes

["H. Peter Anvin" <hpa@zytor.com>]

Followup to:  <20010914145352.A9952@stud.tu-muenchen.de>
By author:    Matthias Kramm <matthias.kramm@stud.tu-muenchen.de>
In newsgroup: linux.dev.kernel
> According to the (2.4.9) MAINTAINERS-File,  ISOFS doesn't have a maintainer,
> so this probably best fits in this list.
> 
> I came across a (commercial) DVD with an ISOFS Filesystem on it and filesizes
> bigger than 1M.
>

1 GB (not MB) you mean...

> My personal guess would be that the assumption that iso files can't be
> bigger than 1M unless the CD-ROM is defective is wrong.
> (I don't know where the 1M comes from. 2M sounds more logical to me,
>  however)

1 GB comes from the fact that some old CD's actually put garbage in
the upper byte of the file size, so the test triggers if the size is
larger than any CD can be.  Unfortunately, DVDs are a lot bigger than
CDs and that assumption is no longer correct.

> After removing the "indode->i_size > 1073741824" test, I got the correct
> output for ls. Also was I able to cat (css-cat, actually) the whole 1201278976 
> bytes without an error, which may lead to the assumption the file
> is actually that big.
> If I'm wrong and the dvd is actually broken, however, I'd like to 
> suggest making the automatic cruft mount optional.

The automatic cruft mount option should probably be conditionalized
not on a fixed size, but on the actual size of the filesystem.

	-hpa

-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<amsp@zytor.com>