public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcc 3.0.1 warnings about multi-line literals
Date: 22 Oct 2001 13:51:29 -0700	[thread overview]
Message-ID: <9r20sh$aqr$1@cesium.transmeta.com> (raw)
In-Reply-To: <200110222005.f9MK5AJ15012@oss.sgi.com> <20011022161527.K23213@redhat.com>

Followup to:  <20011022161527.K23213@redhat.com>
By author:    Benjamin LaHaise <bcrl@redhat.com>
In newsgroup: linux.dev.kernel
>
> On Mon, Oct 22, 2001 at 01:05:10PM -0700, John Hawkes wrote:
> > This patch eliminates gcc 3.0.1 warnings, "multi-line string literals are
> > deprecated", in two include/asm-i386 files.  Patches cleanly for at least
> > 2.4.10 and 2.4.12, and tested in 2.4.10.
> 
> Please reject this patch.  The gcc folks are wrong in this case.
> 

It's not gcc even, it's C99 which are making these explicitly
deprecated.  If you want a string literal which includes \n and are
mapped in that form, do either:

       "foo\n"
       "bar\n"
       "baz\n"

... or ..

	"foo\n\
	bar\n\
	baz"

I usually do the former.

	-hpa
-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<amsp@zytor.com>

      parent reply	other threads:[~2001-10-22 20:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-22 20:05 [PATCH] gcc 3.0.1 warnings about multi-line literals John Hawkes
2001-10-22 20:15 ` Benjamin LaHaise
2001-10-22 20:45   ` Alan Cox
2001-10-22 20:51     ` Benjamin LaHaise
2001-10-22 21:39       ` David S. Miller
2001-10-23 12:04         ` David Howells
2001-10-25  7:11       ` Richard Henderson
2001-10-25 16:47         ` Benjamin LaHaise
2001-10-22 20:51   ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='9r20sh$aqr$1@cesium.transmeta.com' \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox