Re: Linux 2.4.13-ac4

Vojtech Pavlik
2001-10-29T17:47:52Z

On Mon, Oct 29, 2001 at 10:56:35AM +0000, Alan Cox wrote:

> > bytes read from the 8254 get swapped. I've got some indirect evidence
> > that this also could happen with the original i8254.
>
> Im hoping not. That would imply we interrupted someone half way through
> reading the counter which means the locking is screwed up.
>
> > By the way, if we made the 8254 accesses (spinlock?) protected (which
> > should be done anyway, right now definitely more than one CPU can access
> > the registers at once), I think we could remove the outb(0, 0x43);,
> > saving some cycles.
>
> Some chipsets need the outb

I'm looking at how to cleanly fix the timer accesses. And I think a
common inline function that does the

lock
outb
inb
inb
check - via, other bugs
unlock

would make sense. What do you think?

--
Vojtech Pavlik
SuSE Labs