From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE03C364053 for ; Fri, 22 May 2026 09:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779440841; cv=none; b=DBUCpnYw2dPQO8AToc9I15KhYNeNSZ7aY6jDNShnPbGUJKirnLGyPPyYF49QAysRt71VQKjqEW5pLgibVQoC8dRXTvQfqNKa/ydC4VqWgUsb/lItCR5zYxRVyXJXyr4pDfOWxgXvUeJuUqfAZwmfbrT8FiHPUQhG/6nbjfTKOcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779440841; c=relaxed/simple; bh=5nUM04+Oakpa9Cj4TWrMW9fEn3Kk+NVFqR1pcLe6/gg=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=W2v/lOPMJf7vTO4oJYJ879dMq1n/kRnylHoIQPYMRnmtpgRh1rDgLsscu3z3Qxda2k1l8dEUVk4D04qMlgyP+X7tfYHV1uenpKo5Y4F3S32uGmOQOm2TLJHpcgJCBtK8P6s4pwIQwB02R8KscplcMjI4ldJe6gbmJugzC4UVYSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=kVMY/Otz; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="kVMY/Otz" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779440837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5nUM04+Oakpa9Cj4TWrMW9fEn3Kk+NVFqR1pcLe6/gg=; b=kVMY/OtzdFq6iqxzCMMwayWxsSWMY+CExELm4bPfWtHv+NUhZ7ovfrKPHfkEWe6tD9xP0W ouUAkCmWjJ7g8pcptkLRtK535VvcrcUzKHC7wTqTQB34PQjQqnqc5GwHZi5c0QCKRmS67B 47wgP7fANk1PZvbaoaWBdmZdVMDaGiU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v2 19/69] mm/mm_init: Make __init_page_from_nid() static X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <177944019670.3663073.4082076266566320906.b4-review@b4> Date: Fri, 22 May 2026 17:06:28 +0800 Cc: Muchun Song , Andrew Morton , David Hildenbrand , Oscar Salvador , Michael Ellerman , Madhavan Srinivasan , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nicholas Piggin , Christophe Leroy , Ackerley Tng , Frank van der Linden , aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260513130542.35604-1-songmuchun@bytedance.com> <20260513130542.35604-20-songmuchun@bytedance.com> <177944019670.3663073.4082076266566320906.b4-review@b4> To: Mike Rapoport X-Migadu-Flow: FLOW_OUT > On May 22, 2026, at 16:56, Mike Rapoport wrote: >=20 > On Wed, 13 May 2026 21:04:47 +0800, Muchun Song = wrote: >> __init_page_from_nid() no longer has external users and is only used >> locally in mm/mm_init.c under CONFIG_DEFERRED_STRUCT_PAGE_INIT. >>=20 >> Make it static and keep it inside that block. >=20 > Can we just fold it into its sole caller init_deferred_page() please? Yes. I can do that next version. Thanks Muchun >=20 > --=20 > Sincerely yours, > Mike. >=20