From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: michael-dev@fami-braun.de, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Matt Mackall <mpm@selenic.com>,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [BUG] SLOB breaks Crypto
Date: Mon, 17 May 2010 18:17:14 +0200 [thread overview]
Message-ID: <AANLkTilPEnh3ewTb-KDsReBpjcszh1wkbfZohIaPXBKe@mail.gmail.com> (raw)
In-Reply-To: <20100319003351.GC20227@gondor.apana.org.au>
On Fri, Mar 19, 2010 at 02:33, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Thu, Mar 18, 2010 at 10:24:41PM +0100, michael-dev@fami-braun.de wrote:
>>
>> Pekka Enberg schrieb:
>> > Even with CONFIG_DEBUG_SLAB enabled or with CONFIG_SLUB and
>> > CONFIG_SLUB_DEBUG_ON?
>>
>> no, these options have not been / are not enabled.
>
> Can you please try it with those options enabled? That will tell
> us if there is some latent bug in the crypto layer that only shows
> up right away under SLOB.
After seeing a posting from Nemoto-san on the linux-mips list (should
show up soon on
http://www.linux-mips.org/archives/linux-mips/2010-05/threads.html),
I'm wondering if these defaults are the culprit;
mm/slab.c:#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
mm/slob.c:#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long)
mm/slub.c:#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
Note that some platforms override this.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2010-05-17 16:17 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 13:39 [BUG] SLOB breaks Crypto michael-dev
2010-03-18 16:30 ` Pekka Enberg
2010-03-18 21:24 ` michael-dev
2010-03-19 0:33 ` Herbert Xu
2010-05-14 14:50 ` Adrian-Ken Rueegsegger
2010-05-17 16:17 ` Geert Uytterhoeven [this message]
2010-05-17 21:50 ` Adrian-Ken Rueegsegger
2010-05-17 22:37 ` Matt Mackall
2010-05-18 8:17 ` Adrian-Ken Rueegsegger
2010-05-18 10:27 ` Herbert Xu
2010-05-18 14:02 ` Pekka Enberg
2010-05-18 19:06 ` Matt Mackall
2010-05-18 19:25 ` David Miller
2010-05-18 19:33 ` Matt Mackall
2010-05-18 20:59 ` David Miller
2010-05-18 21:15 ` Pekka Enberg
2010-05-18 21:20 ` David Miller
2010-05-18 22:35 ` Paul Mundt
2010-05-18 22:37 ` Paul Mundt
2010-05-19 15:19 ` Christoph Lameter
2010-05-19 19:56 ` David Miller
2010-05-18 22:40 ` David Miller
2010-05-18 23:10 ` Paul Mundt
2010-05-18 23:16 ` Matt Mackall
2010-05-19 5:53 ` Pekka Enberg
2010-05-18 23:20 ` David Woodhouse
2010-05-19 1:05 ` Herbert Xu
2010-05-19 7:14 ` David Woodhouse
2010-05-19 7:45 ` Herbert Xu
2010-05-19 11:32 ` Geert Uytterhoeven
2010-05-19 11:40 ` David Woodhouse
2010-05-19 11:50 ` Geert Uytterhoeven
2010-05-19 14:11 ` Matt Mackall
2010-05-19 19:33 ` David Miller
2010-05-20 3:38 ` FUJITA Tomonori
2010-05-20 3:46 ` David Miller
2010-05-19 12:02 ` FUJITA Tomonori
2010-05-19 12:19 ` David Woodhouse
2010-05-19 12:26 ` FUJITA Tomonori
2010-05-19 12:48 ` David Woodhouse
2010-05-19 10:58 ` David Woodhouse
2010-05-19 11:01 ` [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slab_def.h> David Woodhouse
2010-05-19 13:30 ` Johannes Stezenbach
2010-05-19 18:03 ` Manfred Spraul
2010-05-19 18:10 ` David Woodhouse
2010-05-20 16:49 ` Manfred Spraul
2010-05-19 19:11 ` Pekka Enberg
2010-05-19 19:19 ` Christoph Lameter
2010-05-19 19:23 ` Pekka Enberg
2010-05-19 19:45 ` Christoph Lameter
2010-05-19 19:28 ` David Woodhouse
2010-05-19 11:01 ` [PATCH 2/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slob_def.h> David Woodhouse
2010-05-19 11:02 ` [PATCH 3/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slub_def.h> David Woodhouse
2010-05-19 11:02 ` [PATCH 4/4] crypto: Use ARCH_KMALLOC_MINALIGN for CRYPTO_MINALIGN now that it's exposed David Woodhouse
2010-05-19 11:08 ` [BUG] SLOB breaks Crypto Pekka Enberg
2010-05-19 11:16 ` David Woodhouse
2010-05-19 11:46 ` Herbert Xu
2010-05-19 12:54 ` Pekka Enberg
2010-05-19 12:59 ` Herbert Xu
2010-05-19 19:51 ` David Miller
2010-05-19 19:42 ` David Miller
2010-05-19 13:49 ` [PATCH 5/4] Provide __dma_aligned macro David Woodhouse
2010-05-19 14:50 ` FUJITA Tomonori
2010-05-19 4:09 ` [BUG] SLOB breaks Crypto Herbert Xu
2010-05-19 5:44 ` Pekka Enberg
2010-05-18 19:32 ` Adrian-Ken Rueegsegger
2010-05-18 22:39 ` Herbert Xu
2010-05-19 1:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilPEnh3ewTb-KDsReBpjcszh1wkbfZohIaPXBKe@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).