From: Mike Frysinger <vapier.adi@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: uclinux-dev@uclinux.org, David Howells <dhowells@redhat.com>,
David McCullough <davidm@snapgear.com>,
Greg Ungerer <gerg@uclinux.org>, Paul Mundt <lethal@linux-sh.org>,
uclinux-dist-devel@blackfin.uclinux.org,
microblaze-uclinux@itee.uq.edu.au,
Michal Simek <monstr@monstr.eu>,
linux-m32r@ml.linux-m32r.org,
Hirokazu Takata <takata@linux-m32r.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH 1/2 v2] FLAT: split the stack & data alignments
Date: Fri, 28 May 2010 02:05:27 -0400 [thread overview]
Message-ID: <AANLkTilUCAoppSG7TIWyUqVa98ItoFHTh_lxA6Fl8l8g@mail.gmail.com> (raw)
In-Reply-To: <1274863506-14168-1-git-send-email-vapier@gentoo.org>
On Wed, May 26, 2010 at 04:45, Mike Frysinger wrote:
> The stack and data have different alignment requirements, so don't force
> them to wear the same shoe. Increase the data alignment to match that
> which the elf2flt linker script has always been using: 0x20 bytes. Not
> only does this bring the kernel loader in line with the toolchain, but
> it also fixes a swath of gcc tests which try to force larger alignment
> values but randomly fail when the FLAT loader fails to deliver.
btw, a follow up patch might be to move the shared lib identifiers
from the start of the data section to the end of it so that the
re-aligning isnt necessary (we'd get a 4k page alignment from mmap and
such). but i cant seem to figure out how these identifiers are being
read/written. otherwise, the fact that we're force aligning to 0x20
bytes means that there is always room for 8 identifiers ... no point
in flipping between 1 or 4, at least from this point of view ...
-mike
next prev parent reply other threads:[~2010-05-28 6:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 19:24 [PATCH] FLAT: allow arches to declare a larger alignment than the slab Mike Frysinger
2010-05-25 19:50 ` Geert Uytterhoeven
2010-05-25 21:07 ` Paul Mundt
2010-05-25 23:17 ` Mike Frysinger
2010-05-26 2:23 ` Jie Zhang
2010-05-26 6:59 ` Geert Uytterhoeven
2010-05-26 7:23 ` Mike Frysinger
2010-05-26 7:33 ` Paul Mundt
2010-05-26 7:36 ` Mike Frysinger
2010-05-26 7:36 ` Mike Frysinger
2010-05-26 7:48 ` Paul Mundt
2010-05-26 8:01 ` Mike Frysinger
2010-05-26 7:24 ` Michal Simek
2010-05-26 8:45 ` [PATCH 1/2 v2] FLAT: split the stack & data alignments Mike Frysinger
2010-05-27 8:24 ` Michal Simek
2010-05-27 18:30 ` [Uclinux-dist-devel] " Mike Frysinger
2010-05-27 23:15 ` [microblaze-uclinux] " David McCullough
2010-05-28 4:57 ` Mike Frysinger
2010-05-28 6:05 ` Mike Frysinger [this message]
2010-05-28 6:23 ` David McCullough
2010-05-28 6:40 ` Greg Ungerer
2010-05-26 8:45 ` [PATCH 2/2 v2] FLAT: tweak default stack alignment Mike Frysinger
2010-05-28 6:24 ` David McCullough
2010-05-28 6:39 ` Greg Ungerer
2010-06-06 7:12 ` [PATCH v3] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilUCAoppSG7TIWyUqVa98ItoFHTh_lxA6Fl8l8g@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=takata@linux-m32r.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).