From: Stephane Eranian <eranian@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: eranian@gmail.com, Corey Ashford <cjashfor@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [BUG] perf_event: when events are grouped, the time enabled / running values are incorrect
Date: Tue, 11 May 2010 22:23:38 +0200 [thread overview]
Message-ID: <AANLkTilVGy3nLymHUj-blglsL3y5ApyhUWrunxJYeQPb@mail.gmail.com> (raw)
In-Reply-To: <1273608676.1810.61.camel@laptop>
On Tue, May 11, 2010 at 10:11 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, 2010-05-11 at 21:55 +0200, stephane eranian wrote:
>> Events are also grouped in this example. Both this same issue exists
>> also when only
>> one event is used. I suspect an update_event_times() or
>> update_group_times() is also
>> missing on the sampling path in perf_overflow_handler().
>
> Hrmm, you're right, except fixing that is non-trivial.
> update_event_times() wants to be called with ctx->lock held and we can't
> do that from NMI context.
>
Why do you need the lock when the event is running on a CPU in NMI context?
What action issued remotely could modify the data used by this function without
the need for IPI?
next prev parent reply other threads:[~2010-05-11 20:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 1:56 [BUG] perf_event: when events are grouped, the time enabled / running values are incorrect Corey Ashford
2010-05-08 2:24 ` Corey Ashford
2010-05-11 14:42 ` Peter Zijlstra
2010-05-11 15:43 ` [tip:perf/core] perf: Fix exit() vs event-groups tip-bot for Peter Zijlstra
2010-05-11 19:55 ` [BUG] perf_event: when events are grouped, the time enabled / running values are incorrect stephane eranian
2010-05-11 20:11 ` Peter Zijlstra
2010-05-11 20:23 ` Stephane Eranian [this message]
2010-05-11 20:27 ` Peter Zijlstra
2010-05-12 17:25 ` Corey Ashford
2010-05-12 17:50 ` Peter Zijlstra
2010-05-12 18:15 ` Corey Ashford
2010-05-12 18:42 ` Corey Ashford
2010-05-13 0:10 ` Paul Mackerras
2010-05-13 10:17 ` Paul Mackerras
2010-05-13 17:37 ` Corey Ashford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilVGy3nLymHUj-blglsL3y5ApyhUWrunxJYeQPb@mail.gmail.com \
--to=eranian@google.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).