* [PATCH] IPVS : bugfix for ICMPv6 checksum calculation
@ 2010-08-12 1:39 xiaoyu Du
2010-08-12 5:48 ` xiaoyu Du
0 siblings, 1 reply; 3+ messages in thread
From: xiaoyu Du @ 2010-08-12 1:39 UTC (permalink / raw)
To: linux-kernel, Simon Horman, lvs-devel
Hi:
This patch correct the ICMPv6 checksum calculation when IPv6 vs is used.
Signed-off-by: Xiaoyu Du <tingsrain@gmail.com>
---
net/netfilter/ipvs/ip_vs_core.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index 4f8ddba..124a1ae 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -638,8 +638,12 @@ void ip_vs_nat_icmp_v6(struct sk_buff *skb,
struct ip_vs_protocol *pp,
/* And finally the ICMP checksum */
icmph->icmp6_cksum = 0;
- /* TODO IPv6: is this correct for ICMPv6? */
ip_vs_checksum_complete(skb, icmp_offset);
+ icmph->icmp6_cksum = csum_ipv6_magic(&iph->saddr,
+ &iph->daddr,
+ skb->len - icmp_offset, IPPROTO_ICMPV6,
+ skb->csum);
+
skb->ip_summed = CHECKSUM_UNNECESSARY;
if (inout)
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IPVS : bugfix for ICMPv6 checksum calculation
2010-08-12 1:39 [PATCH] IPVS : bugfix for ICMPv6 checksum calculation xiaoyu Du
@ 2010-08-12 5:48 ` xiaoyu Du
2010-08-17 7:00 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: xiaoyu Du @ 2010-08-12 5:48 UTC (permalink / raw)
To: linux-kernel, Simon Horman, lvs-devel
forgive my careless and poor english , "correct" should be "corrects".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IPVS : bugfix for ICMPv6 checksum calculation
2010-08-12 5:48 ` xiaoyu Du
@ 2010-08-17 7:00 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2010-08-17 7:00 UTC (permalink / raw)
To: xiaoyu Du; +Cc: linux-kernel, lvs-devel
On Thu, Aug 12, 2010 at 01:48:02PM +0800, xiaoyu Du wrote:
> forgive my careless and poor english , "correct" should be "corrects".
Thanks, got it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-17 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-12 1:39 [PATCH] IPVS : bugfix for ICMPv6 checksum calculation xiaoyu Du
2010-08-12 5:48 ` xiaoyu Du
2010-08-17 7:00 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).