Re: [PATCH 01/16] x86: Kill unused static boot_cpu_logical_apicid in smpboot.c

[Yinghai Lu <yinghai@kernel.org>]

On Sun, Jan 23, 2011 at 5:37 AM, Tejun Heo <tj@kernel.org> wrote:
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reviewed-by: Pekka Enberg <penberg@kernel.org>
> ---
>  arch/x86/kernel/smpboot.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 763df77..c255980 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -165,8 +165,6 @@ static void unmap_cpu_to_node(int cpu)
>  #endif
>
>  #ifdef CONFIG_X86_32
> -static int boot_cpu_logical_apicid;
> -
>  u8 cpu_2_logical_apicid[NR_CPUS] __read_mostly =
>                                        { [0 ... NR_CPUS-1] = BAD_APICID };
>
> @@ -1096,9 +1094,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus)
>         * Setup boot CPU information
>         */
>        smp_store_cpu_info(0); /* Final full version of the data */
> -#ifdef CONFIG_X86_32
> -       boot_cpu_logical_apicid = logical_smp_processor_id();
> -#endif
> +
>        current_thread_info()->cpu = 0;  /* needed? */
>        for_each_possible_cpu(i) {
>                zalloc_cpumask_var(&per_cpu(cpu_sibling_map, i), GFP_KERNEL);

Acked-by: Yinghai Lu <yinghai@kernel.org>