From: Corentin Chary <corentin.chary@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>,
Yong Wang <yong.y.wang@intel.com>, Dmitry Torokhov <dtor@mail.ru>,
Tejun Heo <tj@kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] drivers/platform/x86/eeepc-wmi.c: fix build warning
Date: Wed, 19 May 2010 14:06:46 +0200 [thread overview]
Message-ID: <AANLkTimTjuQUEulo8g7clpECJVHwwDc29nkWskw6fWF-@mail.gmail.com> (raw)
In-Reply-To: <1274265421-26747-1-git-send-email-daniel@caiaq.de>
On Wed, May 19, 2010 at 12:37 PM, Daniel Mack <daniel@caiaq.de> wrote:
> drivers/platform/x86/eeepc-wmi.c: In function ‘eeepc_wmi_notify’:
> drivers/platform/x86/eeepc-wmi.c:209: warning: ‘new’ may be used uninitialized in this function
> drivers/platform/x86/eeepc-wmi.c:209: note: ‘new’ was declared here
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Yong Wang <yong.y.wang@intel.com>
> Cc: Corentin Chary <corentincj@iksaif.net>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: platform-driver-x86@vger.kernel.org
> ---
> drivers/platform/x86/eeepc-wmi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
> index b227eb4..9dc50fb 100644
> --- a/drivers/platform/x86/eeepc-wmi.c
> +++ b/drivers/platform/x86/eeepc-wmi.c
> @@ -206,7 +206,7 @@ static int eeepc_wmi_backlight_notify(struct eeepc_wmi *eeepc, int code)
> {
> struct backlight_device *bd = eeepc->backlight_device;
> int old = bd->props.brightness;
> - int new;
> + int new = old;
>
> if (code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNUP_MAX)
> new = code - NOTIFY_BRNUP_MIN + 1;
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-By: Corentin Chary <corentincj@iksaif.net>
--
Corentin Chary
http://xf.iksaif.net
next prev parent reply other threads:[~2010-05-19 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 10:37 [PATCH] drivers/platform/x86/eeepc-wmi.c: fix build warning Daniel Mack
2010-05-19 12:06 ` Corentin Chary [this message]
2010-05-20 13:43 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimTjuQUEulo8g7clpECJVHwwDc29nkWskw6fWF-@mail.gmail.com \
--to=corentin.chary@gmail.com \
--cc=daniel@caiaq.de \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).