From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758059Ab0ERT2q (ORCPT ); Tue, 18 May 2010 15:28:46 -0400 Received: from mail-gw0-f46.google.com ([74.125.83.46]:51141 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754572Ab0ERT2p (ORCPT ); Tue, 18 May 2010 15:28:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=tXqCJ8Yi3yz/HkJCNlL6enbPU5YJ6InZb8Tu08PeGmdnkeyoX+3owU+wTC3aQiElvL R4OFXFYFHShFLzOn8PyRYRXusbGBA51+gpXlKK2clGZCZCB7+PnFYzEiE5wJw4bzv2Lz kR5Fc99pUfROP8diKCC++MerewIvgmeG7KAUU= MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 18 May 2010 14:28:39 -0500 Message-ID: Subject: Re: PREEMPT_RT (2.6.33-rt17) disabled printk-to-console after console_init From: Xianghua Xiao To: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2010 at 8:13 AM, Xianghua Xiao wrote: > I would like to have printk output to my ttyS0 console all the time, > with 2.6.33-rt17, after kernel is booted up with all messages shown > normally on the serial port until I login in, from this point on, all > printk messages go to 'dmesg(log_buf)' fine, but I could never get > them shown up on serial console anymore. I tried adjust > /proc/sys/kernel/printk etc none helped. > > Switch PREEMPT_RT to PREEMPT_VOLUNTARY and reboot, now everything > works, i.e. I can see printk on my console after I login. > > Look at the RT patch itself, I do find some changes to printk itself, > however I'm unsure what is causing this(i.e printk not going to > console after login). > > Thanks, > Xianghua > Thomas, I could not get dmesg output to console/serial and klogd(/var/log/messages) anymore with 2.6.33-rt17 _after_ the kernel boot is done(on non-RT kernel it works fine). I made below changes it starts to work again, however I'm unsure how safe the change is. Please advise. During googling I found this: http://lkml.org/lkml/2008/1/24/390, fyi. Thanks a lot! Xianghua diff --git a/kernel/printk.c b/kernel/printk.c index 073d27f..48ef843 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -430,7 +430,6 @@ static void __call_console_drivers(unsigned start, unsigned end) for_each_console(con) { if ((con->flags & CON_ENABLED) && con->write && - console_atomic_safe(con) && (cpu_online(raw_smp_processor_id()) || (con->flags & CON_ANYTIME))) { set_printk_might_sleep(1); @@ -1093,9 +1092,6 @@ void release_console_mutex(void) * printk from non-preemptible sections so this is for the emergency * case only. */ -#ifdef CONFIG_PREEMPT_RT - if (!in_atomic() && !irqs_disabled()) -#endif if (wake_klogd) wake_up_klogd(); }