From: Linus Walleij <linus.ml.walleij@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Russell King <rmk@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com
Subject: Re: [PATCH] DMAENGINE: DMA40 U8500 platform configuration
Date: Fri, 28 May 2010 03:11:58 +0200 [thread overview]
Message-ID: <AANLkTinoMmz05KweBJQJ4Tr2cRNTp_SY6NOuX1GRzEcK@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikPB3hD4EkvI9x1KPOWIU-HADLWDHi5jqij-oqs@mail.gmail.com>
2010/5/28 Dan Williams <dan.j.williams@intel.com>:
> On Thu, May 27, 2010 at 3:12 PM, Russell King <rmk@arm.linux.org.uk> wrote:
>> On Thu, May 27, 2010 at 02:59:51PM -0700, Dan Williams wrote:
>>> On Thu, May 27, 2010 at 12:37 PM, Russell King <rmk@arm.linux.org.uk> wrote:
>>> > On Wed, May 26, 2010 at 09:17:42AM -0700, Dan Williams wrote:
>>> >> Requesting acked-by for:
>>> >>
>>> >> http://marc.info/?l=linux-kernel&m=127434177015990&w=2
>>> >
>>> > Well...
>>> >
>>> > +const static dma_addr_t dma40_tx_map[STEDMA40_NR_DEV] = {
>>> > +const static dma_addr_t dma40_rx_map[STEDMA40_NR_DEV] = {
>>>
>>> Yeah, no need to initialize static data to 0, I'll fix that up before
>>> submitting.
>>
>> static const
>>
>> not
>>
>> const static
>>
>
> Ah thanks, I was going to check into that and got distracted by the
> zero initializers...
>
> Also fixed up.
Thanks for fixing this Dan, appreciated!
Yours,
Linus Walleij
prev parent reply other threads:[~2010-05-28 1:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 7:49 [PATCH] DMAENGINE: DMA40 U8500 platform configuration Linus Walleij
2010-05-23 23:02 ` Dan Williams
2010-05-26 16:17 ` Dan Williams
2010-05-27 19:37 ` Russell King
2010-05-27 21:59 ` Dan Williams
2010-05-27 22:12 ` Russell King
2010-05-27 22:19 ` Dan Williams
2010-05-28 1:11 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinoMmz05KweBJQJ4Tr2cRNTp_SY6NOuX1GRzEcK@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=dan.j.williams@intel.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).