From: Paul Cercueil <paul@crapouillou.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] leds: max8997: Don't error if there is no pdata
Date: Fri, 21 Oct 2022 14:19:58 +0100 [thread overview]
Message-ID: <ADU3KR.HZPTLZCKPHT63@crapouillou.net> (raw)
In-Reply-To: <20221021131145.GB16264@duo.ucw.cz>
Le ven. 21 oct. 2022 à 15:11:45 +0200, Pavel Machek <pavel@ucw.cz> a
écrit :
> On Thu 2022-10-20 12:44:42, Paul Cercueil wrote:
>> The driver works just fine if no platform data is supplied.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Does it? Bad Paul, bad Andy.
Yes, it does.
>> +++ b/drivers/leds/leds-max8997.c
>> @@ -238,11 +238,6 @@ static int max8997_led_probe(struct
>> platform_device *pdev)
>> char name[20];
>> int ret = 0;
>>
>> - if (pdata == NULL) {
>> - dev_err(&pdev->dev, "no platform data\n");
>> - return -ENODEV;
>> - }
>> -
>> led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
>> if (led == NULL)
>> return -ENOMEM;
>> @@ -258,7 +253,7 @@ static int max8997_led_probe(struct
>> platform_device *pdev)
>> led->iodev = iodev;
>>
>> /* initialize mode and brightness according to platform_data */
>> - if (pdata->led_pdata) {
>> + if (pdata && pdata->led_pdata) {
>> u8 mode = 0, brightness = 0;
>>
>> mode = pdata->led_pdata->mode[led->id];
>
> I see pdata being dereferenced here.
Oh really. Look again.
-Paul
next prev parent reply other threads:[~2022-10-21 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 11:44 [PATCH v2] leds: max8997: Don't error if there is no pdata Paul Cercueil
2022-10-21 13:11 ` Pavel Machek
2022-10-21 13:19 ` Paul Cercueil [this message]
2022-10-22 9:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ADU3KR.HZPTLZCKPHT63@crapouillou.net \
--to=paul@crapouillou.net \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox