From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Yixun Lan <dlan@gentoo.org>, Troy Mitchell <troy.mitchell@linux.dev>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Yangyu Chen <cyy@cyyself.name>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: riscv: spacemit: Add MusePi Pro board
Date: Sun, 28 Sep 2025 15:52:31 +0800 [thread overview]
Message-ID: <B015018225608C50+aNjpP35hN9KOyQph@kernel.org> (raw)
In-Reply-To: <20250928074914-GYA1344940@gentoo.org>
On Sun, Sep 28, 2025 at 03:49:14PM +0800, Yixun Lan wrote:
> Hi Troy,
>
> On 12:16 Sun 28 Sep , Troy Mitchell wrote:
> > From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> >
> > Document the compatible string for the MusePi Pro [1].
> > It is a 1.8-inch single board computer based on the
> > SpacemiT K1/M1 RISC-V SoC [2].
> you could wrap at slightly more characters, I remember 72 chars
> (haven't spent time to find a formal document link..)
Get it. Thansk.
>
> >
> > Link:
> > https://developer.spacemit.com/documentation?token=YJtdwnvvViPVcmkoPDpcvwfVnrh&type=pdf
> I'd suggest to list core features of this board, while using this link as a complement,
> base on previous experience, vendor may change the link address, thus the link vanish
I see. Thanks for pointing it out.
>
> > [1]
> > https://www.spacemit.com/en/key-stone-k1 [2]
> >
> pleae keep them in one line, no break, and no blank line between SoB,
> something as below
> Link: https://.. [1]
I will. Thanks.
- Troy
>
> > Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> > ---
> > Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > index c56b62a6299ac24d3cdef7edcdfc407dc62a1846..52fe39296031f21d1c28c4f1ea5ca9fe28caf45a 100644
> > --- a/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - enum:
> > - bananapi,bpi-f3
> > - milkv,jupiter
> > + - spacemit,musepi-pro
> > - xunlong,orangepi-rv2
> > - const: spacemit,k1
> >
> >
> > --
> > 2.51.0
> >
>
> --
> Yixun Lan (dlan)
>
next prev parent reply other threads:[~2025-09-28 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 3:46 [PATCH 0/2] riscv: dts: spacemit: Add initial support for MusePi Pro Troy Mitchell
2025-09-28 4:16 ` [PATCH 1/2] dt-bindings: riscv: spacemit: Add MusePi Pro board Troy Mitchell
2025-09-28 4:26 ` Troy Mitchell
2025-09-28 4:56 ` E Shattow
2025-09-28 5:10 ` Troy Mitchell
2025-09-28 7:49 ` Yixun Lan
2025-09-28 7:52 ` Troy Mitchell [this message]
2025-09-29 17:48 ` Conor Dooley
2025-10-09 8:07 ` Troy Mitchell
2025-10-09 15:27 ` Conor Dooley
2025-10-10 0:56 ` Troy Mitchell
2025-09-28 4:16 ` [PATCH 2/2] riscv: dts: spacemit: Add MusePi Pro board device tree Troy Mitchell
2025-09-28 5:05 ` E Shattow
2025-09-28 5:10 ` Troy Mitchell
2025-09-28 8:00 ` Yixun Lan
2025-09-28 8:05 ` Troy Mitchell
2025-09-28 8:50 ` Yixun Lan
2025-09-28 9:04 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B015018225608C50+aNjpP35hN9KOyQph@kernel.org \
--to=troy.mitchell@linux.spacemit.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox