From: Song Liu <songliubraving@meta.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Song Liu <songliubraving@meta.com>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Song Liu <song@kernel.org>, bpf <bpf@vger.kernel.org>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kernel Team <kernel-team@meta.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Al Viro <viro@zeniv.linux.org.uk>, KP Singh <kpsingh@kernel.org>,
Matt Bobrowski <mattbobrowski@google.com>
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Extend test fs_kfuncs to cover security.bpf xattr names
Date: Thu, 31 Oct 2024 15:56:54 +0000 [thread overview]
Message-ID: <B6CD210E-96C6-4730-BD05-EC3A0C6905EB@fb.com> (raw)
In-Reply-To: <ZyMqOyswxw1s1Jbt@infradead.org>
> On Oct 30, 2024, at 11:56 PM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Oct 30, 2024 at 08:44:26PM +0000, Song Liu wrote:
>> Given bpf kfuncs can read user.* xattrs for almost a year now, I think we
>> cannot simply revert it. We already have some users using it.
>>
>> Instead, we can work on a plan to deprecated it. How about we add a
>> WARN_ON_ONCE as part of this patchset, and then remove user.* support
>> after some time?
>
> As Christian mentioned having bpf access to user xattrs is probably
> not a big issue. OTOH anything that makes security decisions based
> on it is probably pretty broken. Not sure how you want to best
> handle that.
Agreed that we really need security.bpf prefix for security use cases.
Reading user.* xattrs could be useful for some tracing use cases. We
may also introduce other prefixes for future use cases.
Thanks,
Song
next prev parent reply other threads:[~2024-10-31 15:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 21:46 [PATCH bpf-next 0/2] security.bpf xattr name prefix Song Liu
2024-10-02 21:46 ` [PATCH bpf-next 1/2] fs/xattr: bpf: Introduce " Song Liu
2024-10-07 8:39 ` Jiri Olsa
2024-10-07 17:15 ` Song Liu
2024-10-14 10:18 ` Christian Brauner
2024-10-02 21:46 ` [PATCH bpf-next 2/2] selftests/bpf: Extend test fs_kfuncs to cover security.bpf xattr names Song Liu
2024-10-15 5:07 ` Christoph Hellwig
2024-10-15 5:21 ` Song Liu
2024-10-15 5:25 ` Christoph Hellwig
2024-10-15 5:52 ` Song Liu
2024-10-15 6:42 ` Christoph Hellwig
2024-10-15 13:54 ` Song Liu
2024-10-16 7:49 ` Christoph Hellwig
2024-10-16 13:51 ` Jan Kara
2024-10-16 14:51 ` Christian Brauner
2024-10-16 16:38 ` Song Liu
2024-10-17 15:03 ` Christoph Hellwig
2024-10-21 13:24 ` Christian Brauner
2024-10-23 6:45 ` Christoph Hellwig
2024-10-30 20:44 ` Song Liu
2024-10-31 6:56 ` Christoph Hellwig
2024-10-31 15:56 ` Song Liu [this message]
2024-10-31 16:10 ` Alexei Starovoitov
2024-10-11 17:40 ` [PATCH bpf-next 0/2] security.bpf xattr name prefix Song Liu
2024-10-14 10:18 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B6CD210E-96C6-4730-BD05-EC3A0C6905EB@fb.com \
--to=songliubraving@meta.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox