From: Song Liu <songliubraving@fb.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/3] perf skel: Remove some unused variables.
Date: Sat, 6 Mar 2021 19:33:09 +0000 [thread overview]
Message-ID: <BA2B7D75-9ABC-4666-82FC-0AE1A0729372@fb.com> (raw)
In-Reply-To: <20210306080840.3785816-1-irogers@google.com>
> On Mar 6, 2021, at 12:08 AM, Ian Rogers <irogers@google.com> wrote:
>
> Fixes -Wall warnings.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Song Liu <songliubraving@fb.com>
Thanks for the clean up!
> ---
> tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c b/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> index c7cec92d0236..ab12b4c4ece2 100644
> --- a/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> +++ b/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> @@ -52,7 +52,7 @@ int BPF_PROG(fentry_XXX)
> static inline void
> fexit_update_maps(struct bpf_perf_event_value *after)
> {
> - struct bpf_perf_event_value *before, diff, *accum;
> + struct bpf_perf_event_value *before, diff;
> __u32 zero = 0;
>
> before = bpf_map_lookup_elem(&fentry_readings, &zero);
> @@ -78,7 +78,6 @@ int BPF_PROG(fexit_XXX)
> {
> struct bpf_perf_event_value reading;
> __u32 cpu = bpf_get_smp_processor_id();
> - __u32 one = 1, zero = 0;
> int err;
>
> /* read all events before updating the maps, to reduce error */
> --
> 2.30.1.766.gb4fecdf3b7-goog
>
prev parent reply other threads:[~2021-03-06 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 8:08 [PATCH 1/3] perf skel: Remove some unused variables Ian Rogers
2021-03-06 8:08 ` [PATCH 2/3] perf tool: Enable warnings when compiling BPF programs Ian Rogers
2021-03-06 19:33 ` Song Liu
2021-03-06 8:08 ` [PATCH 3/3] perf bpf: Minor whitespace cleanup Ian Rogers
2021-03-06 19:34 ` Song Liu
2021-03-06 12:49 ` [PATCH 1/3] perf skel: Remove some unused variables Arnaldo Carvalho de Melo
2021-03-06 19:33 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BA2B7D75-9ABC-4666-82FC-0AE1A0729372@fb.com \
--to=songliubraving@fb.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox