* [PATCH] kbuild: fix sed error in export_report.pl
@ 2011-04-25 23:51 Peter Foley
2011-04-26 6:40 ` Arnaud Lacombe
2011-04-26 14:40 ` Michal Marek
0 siblings, 2 replies; 6+ messages in thread
From: Peter Foley @ 2011-04-25 23:51 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-kbuild, mmarek
This patch fixes a sed error in export_report.pl by escaping a $.
Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
scripts/export_report.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/export_report.pl b/scripts/export_report.pl
index 04dce7c..91fa5a2 100644
--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -50,7 +50,7 @@ sub usage {
sub collectcfiles {
my @file
- = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
+ = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;
chomp @file;
return @file;
}
--
1.7.5.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] kbuild: fix sed error in export_report.pl
2011-04-25 23:51 [PATCH] kbuild: fix sed error in export_report.pl Peter Foley
@ 2011-04-26 6:40 ` Arnaud Lacombe
2011-04-26 14:17 ` Peter Foley
2011-04-26 14:40 ` Michal Marek
1 sibling, 1 reply; 6+ messages in thread
From: Arnaud Lacombe @ 2011-04-26 6:40 UTC (permalink / raw)
To: pefoley2; +Cc: linux-kernel, linux-kbuild, mmarek
Hi,
On Mon, Apr 25, 2011 at 7:51 PM, Peter Foley <pefoley2@verizon.net> wrote:
> This patch fixes a sed error in export_report.pl by escaping a $.
>
Which error ?
Thanks,
- Arnaud
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
> scripts/export_report.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
> index 04dce7c..91fa5a2 100644
> --- a/scripts/export_report.pl
> +++ b/scripts/export_report.pl
> @@ -50,7 +50,7 @@ sub usage {
> sub collectcfiles {
> my @file
> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
> + = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;
> chomp @file;
> return @file;
> }
> --
> 1.7.5.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kbuild: fix sed error in export_report.pl
2011-04-26 6:40 ` Arnaud Lacombe
@ 2011-04-26 14:17 ` Peter Foley
2011-04-26 14:27 ` Américo Wang
0 siblings, 1 reply; 6+ messages in thread
From: Peter Foley @ 2011-04-26 14:17 UTC (permalink / raw)
To: Arnaud Lacombe; +Cc: linux-kernel, linux-kbuild, mmarek
On 4/26/2011 2:40 AM, Arnaud Lacombe wrote:
> Hi,
>
> On Mon, Apr 25, 2011 at 7:51 PM, Peter Foley <pefoley2@verizon.net> wrote:
>> This patch fixes a sed error in export_report.pl by escaping a $.
>>
> Which error ?
>
> Thanks,
> - Arnaud
>
This is the error I get:
make -C /usr/src/git O=/root/linux/t/. export_report
perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command
sh: line 1: .mod.c/: No such file or directory
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild: fix sed error in export_report.pl
2011-04-26 14:17 ` Peter Foley
@ 2011-04-26 14:27 ` Américo Wang
0 siblings, 0 replies; 6+ messages in thread
From: Américo Wang @ 2011-04-26 14:27 UTC (permalink / raw)
To: pefoley2; +Cc: Arnaud Lacombe, linux-kernel, linux-kbuild, mmarek
On Tue, Apr 26, 2011 at 10:17 PM, Peter Foley <pefoley2@verizon.net> wrote:
> On 4/26/2011 2:40 AM, Arnaud Lacombe wrote:
>> Hi,
>>
>> On Mon, Apr 25, 2011 at 7:51 PM, Peter Foley <pefoley2@verizon.net> wrote:
>>> This patch fixes a sed error in export_report.pl by escaping a $.
>>>
>> Which error ?
>>
>> Thanks,
>> - Arnaud
>>
>
> This is the error I get:
>
> make -C /usr/src/git O=/root/linux/t/. export_report
> perl /usr/src/git/scripts/export_report.pl
> sed: -e expression #1, char 5: unterminated `s' command
> sh: line 1: .mod.c/: No such file or directory
Please include this in your changelog.
But anyway,
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild: fix sed error in export_report.pl
2011-04-25 23:51 [PATCH] kbuild: fix sed error in export_report.pl Peter Foley
2011-04-26 6:40 ` Arnaud Lacombe
@ 2011-04-26 14:40 ` Michal Marek
2011-04-26 21:10 ` Peter Foley
1 sibling, 1 reply; 6+ messages in thread
From: Michal Marek @ 2011-04-26 14:40 UTC (permalink / raw)
To: pefoley2; +Cc: linux-kernel, linux-kbuild
On 26.4.2011 01:51, Peter Foley wrote:
> This patch fixes a sed error in export_report.pl by escaping a $.
>
> Signed-off-by: Peter Foley<pefoley2@verizon.net>
> ---
> scripts/export_report.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
> index 04dce7c..91fa5a2 100644
> --- a/scripts/export_report.pl
> +++ b/scripts/export_report.pl
> @@ -50,7 +50,7 @@ sub usage {
> sub collectcfiles {
> my @file
> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
> + = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;
Please enclose the argument in single quotes instead.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kbuild: fix sed error in export_report.pl
2011-04-26 14:40 ` Michal Marek
@ 2011-04-26 21:10 ` Peter Foley
0 siblings, 0 replies; 6+ messages in thread
From: Peter Foley @ 2011-04-26 21:10 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kernel, linux-kbuild
On 4/26/2011 10:40 AM, Michal Marek wrote:
> On 26.4.2011 01:51, Peter Foley wrote:
>> This patch fixes a sed error in export_report.pl by escaping a $.
>>
>> Signed-off-by: Peter Foley<pefoley2@verizon.net>
>> ---
>> scripts/export_report.pl | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
>> index 04dce7c..91fa5a2 100644
>> --- a/scripts/export_report.pl
>> +++ b/scripts/export_report.pl
>> @@ -50,7 +50,7 @@ sub usage {
>> sub collectcfiles {
>> my @file
>> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
>> + = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed
>> s/\.ko\$/.mod.c/`;
>
> Please enclose the argument in single quotes instead.
>
> Michal
I tried doing that and still got:
perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-26 21:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-25 23:51 [PATCH] kbuild: fix sed error in export_report.pl Peter Foley
2011-04-26 6:40 ` Arnaud Lacombe
2011-04-26 14:17 ` Peter Foley
2011-04-26 14:27 ` Américo Wang
2011-04-26 14:40 ` Michal Marek
2011-04-26 21:10 ` Peter Foley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).