Re: [PATCH v4 2/2] apic: Add print error interrupt reason

[Cyrill Gorcunov <gorcunov@gmail.com>]

 heh, drop my prev mail. Patch is good! thanks ans sorry for noise.

On Thursday, April 14, 2011, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> On Thu, Apr 14, 2011 at 10:36 AM, Youquan Song <youquan.song@intel.com> wrote:
>> End user worry about the error interrupt information and intend to know what
>> kind of error interrupts are generated, so this patch add printing out the
>> detail debug information of error interrupt.
>> dynamic debug is not initiated when LAPIC initiation, so the pr_debug will not
>> output the error interrupt debug information when boot.
>> In this patch, we use apic_printk(APIC_DEBUG,), so if add kernel option
>> apic=debug will output the error interrupt during boot.
>>
>> Signed-off-by: Youquan Song <youquan.song@intel.com>
>> Signed-off-by: Joe Perches <joe@perches.com>
>> ---
>>  arch/x86/kernel/apic/apic.c |   38 +++++++++++++++++++++++++-------------
>>  1 files changed, 25 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
>> index fabf01e..3ddf4ef 100644
>> --- a/arch/x86/kernel/apic/apic.c
>> +++ b/arch/x86/kernel/apic/apic.c
>> @@ -1813,6 +1813,17 @@ void smp_spurious_interrupt(struct pt_regs *regs)
>>  void smp_error_interrupt(struct pt_regs *regs)
>>  {
>>        u32 v, v1;
>> +       u32 i = 0;
>> +       static const char * const error_interrupt_reason[] = {
>> +               "Send CS error",                /* APIC Error Bit 0 */
>> +               "Receive CS error",             /* APIC Error Bit 1 */
>> +               "Send accept error",            /* APIC Error Bit 2 */
>> +               "Receive accept error",         /* APIC Error Bit 3 */
>> +               "Redirectable IPI",             /* APIC Error Bit 4 */
>> +               "Send illegal vector",          /* APIC Error Bit 5 */
>> +               "Received illegal vector",      /* APIC Error Bit 6 */
>> +               "Illegal register address",     /* APIC Error Bit 7 */
>> +       };
>>
> ...
>> -       pr_debug("APIC error on CPU%d: %02x(%02x)\n",
>> -               smp_processor_id(), v , v1);
>> +       apic_printk(APIC_DEBUG, KERN_DEBUG "APIC error on CPU%d: %02x(%02x)",
>> +                   smp_processor_id(), v , v1);
>> +
>> +       v1 = v1 & 0xff;
>> +       while (v1) {
>> +               if (v1 & 0x1)
>> +                       apic_printk(APIC_DEBUG, KERN_CONT " : %s",
>> +                                   error_interrupt_reason[i]);
>> +               i++;
>> +               v1 >>= 1;
>> +       };
>> +
>
> Hi looks good but please add some array-checking in case if we get
> some damaged result
> from hardware, ie check for i not being out of error_interrupt_reason. Thanks!
>