From: Mike Frysinger <vapier.adi@gmail.com>
To: Alessio Igor Bogani <abogani@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Tim Abbott <tabbott@ksplice.com>,
Anders Kaseorg <andersk@ksplice.com>,
Jason Wessel <jason.wessel@windriver.com>,
Tim Bird <tim.bird@am.sony.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Embedded <linux-embedded@vger.kernel.org>
Subject: Re: [PATCH 0/4] Speed up the symbols' resolution process V4
Date: Thu, 12 May 2011 10:30:34 -0400 [thread overview]
Message-ID: <BANLkTikyR7ByAgxtbz-gOHspLMFo4a+vaQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=fhsSP069WMNPN8BA=E1=1TZ6Zmw@mail.gmail.com>
On Thu, May 12, 2011 at 05:10, Alessio Igor Bogani wrote:
> 2011/5/11 Mike Frysinger:
> [...]
>> if you export _foo/foo, you'll get an error with the current code:
>> /* EXPORT_SYMBOL(foo); */
>> .section ___ksymtab__foo,"a",@progbits
>> ___ksymtab_foo:
>> /* EXPORT_SYMBOL(_foo); */
>> .section ___ksymtab___foo,"a",@progbits
>> ___ksymtab__foo:
> [...]
>
> So I can suggest two possible solutions for section names:
>
> 1) As you suggested change "__" to "+" so
> i.e. ___ksymtab+foo
>
> 2) Pick a more appropriate name:
> i.e. ___ksym__foo
> or
> i.e. ___ksymsec__foo
>
> In fact these section names aren't a table of symbols (in ksymtab the
> "tab" part stand for table, I suppose) so I think that name should be
> changed accordingly (my patchset create a temporary section for every
> symbol).
>
> Which do you prefer?
i suggested the diff split char as i dont know how embedded the
"ksymtab" section name is in the rest of the tree. but if changing
that is an option, that'd work too. either works for me, so whichever
is less effort for you.
-mike
next prev parent reply other threads:[~2011-05-12 14:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 13:26 [PATCH 0/4] Speed up the symbols' resolution process V4 Alessio Igor Bogani
2011-04-16 13:26 ` [PATCH 1/4] module: Restructure each_symbol() code Alessio Igor Bogani
2011-04-19 1:31 ` Rusty Russell
2011-04-16 13:26 ` [PATCH 2/4] module: Sort exported symbols Alessio Igor Bogani
2011-04-16 13:26 ` [PATCH 3/4] lib: Add generic binary search function to the kernel Alessio Igor Bogani
2011-04-16 13:26 ` [PATCH 4/4] module: Use the binary search for symbols resolution Alessio Igor Bogani
2011-04-16 14:08 ` Wanlong Gao
2011-04-16 14:32 ` Wanlong Gao
2011-04-19 1:37 ` Rusty Russell
2011-04-19 1:44 ` Wanlong Gao
2011-04-19 11:35 ` Rusty Russell
2011-04-19 12:46 ` Wanlong Gao
2011-04-27 15:31 ` [PATCH 0/4] Speed up the symbols' resolution process V4 Dirk Behme
2011-05-11 3:32 ` Mike Frysinger
2011-05-11 7:04 ` Alessio Igor Bogani
2011-05-11 9:19 ` Alessio Igor Bogani
2011-05-11 13:44 ` Alessio Igor Bogani
2011-05-11 14:47 ` Mike Frysinger
2011-05-11 15:25 ` Alessio Igor Bogani
2011-05-11 15:52 ` Mike Frysinger
2011-05-12 9:10 ` Alessio Igor Bogani
2011-05-12 14:30 ` Mike Frysinger [this message]
2011-05-13 7:01 ` Alessio Igor Bogani
2011-05-14 17:32 ` Mike Frysinger
2011-05-15 8:28 ` Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikyR7ByAgxtbz-gOHspLMFo4a+vaQ@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=abogani@kernel.org \
--cc=andersk@ksplice.com \
--cc=jason.wessel@windriver.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tabbott@ksplice.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).