Re: [PATCH] sched: remove the next highest_prio in RT scheduling

[Hillf Danton <dhillf@gmail.com>]

On Sat, Jun 4, 2011 at 1:06 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 2011-06-04 at 12:44 +0800, Hillf Danton wrote:
>
>> Both the next and curr reach same result, or incorrect result, before locking
>
> Not quite. curr could be of higher priority than this rq, but next be of
> lower priority. In that case, we still want to skip the rq.
>
> But this patch does simplify things, and I give you credit for that.
> I'll have to run some tests to see how much in practice this occurs, and
> see if it is worth removing and using your method instead.
>
Hi Steve

Big surprise, you work on Saturday!

good weekend

Hillf
>
>> RQ, as the comment says, it is racy. After locking RQ, priority is checked again
>> to pull the correct tasks with no running task included. The difference between
>> the next and curr before locking RQ is the core of the patch that incorrect
>> result could be achieved with no updating the next field.
>>
>> thanks
>>            Hillf
>
>
>