From: Tony Luck <tony.luck@intel.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, Matt_Domsch@dell.com
Subject: Re: [PATCH 2/3] pstore: Add extra context for writes and erases
Date: Mon, 6 Jun 2011 14:43:46 -0700 [thread overview]
Message-ID: <BANLkTimESgP1FMzP8cbKcECLSbEY9Mj3bQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinHYQ14A7vzTxA1c2frxUVE6HWNQg@mail.gmail.com>
On Mon, Jun 6, 2011 at 12:38 PM, Matthew Garrett <mjg@redhat.com> wrote:
- if (owner && !try_module_get(owner)) {
- psinfo = NULL;
- return -EINVAL;
- }
-
Apart from the accidental deletion of this chunk (as discussed on
IRC), it all looks
good to me. The ERST stuff still works, I didn't try the new EFI bits. So you
can have:
Acked-by: Tony Luck <tony.luck@intel.com>
to add to these ... unless I'm the one pushing them to Linus, in which case I'll
add my Signed-off-by for parts 1 & 2
Does someone claim maintainership of drivers/firmware/efivars.c for part3?
-Tony
next prev parent reply other threads:[~2011-06-06 21:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 19:38 [PATCH 1/3] pstore: Extend API Matthew Garrett
2011-06-06 19:38 ` [PATCH 2/3] pstore: Add extra context for writes and erases Matthew Garrett
[not found] ` <BANLkTinHYQ14A7vzTxA1c2frxUVE6HWNQg@mail.gmail.com>
2011-06-06 21:43 ` Tony Luck [this message]
2011-06-06 21:47 ` Matthew Garrett
2011-06-10 4:00 ` Matt Domsch
2011-06-10 7:12 ` Mike Waychison
2011-06-20 22:27 ` Tony Luck
2011-06-20 22:29 ` Mike Waychison
2011-06-06 19:38 ` [PATCH 3/3] efi: Add support for using efivars as a pstore backend Matthew Garrett
2011-06-06 23:11 ` Tony Luck
2011-06-07 15:47 ` Seiji Aguchi
2011-06-07 15:58 ` Matthew Garrett
2011-06-07 18:04 ` Randy Dunlap
2011-06-21 0:56 ` Mike Waychison
2011-06-21 15:10 ` Matthew Garrett
2011-06-21 17:12 ` Tony Luck
2011-06-21 20:16 ` Mike Waychison
2011-06-21 20:18 ` [PATCH 1/4] efivars: String functions Mike Waychison
2011-06-21 20:18 ` [PATCH 2/4] efivars: introduce utf16_strncmp Mike Waychison
2011-06-21 20:18 ` [PATCH 3/4] efivars: Use string functions in pstore_write Mike Waychison
2011-06-21 20:18 ` [PATCH 4/4] efivars: Introduce PSTORE_EFI_ATTRIBUTES Mike Waychison
2011-06-21 20:22 ` [PATCH 3/3] efi: Add support for using efivars as a pstore backend Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimESgP1FMzP8cbKcECLSbEY9Mj3bQ@mail.gmail.com \
--to=tony.luck@intel.com \
--cc=Matt_Domsch@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).