From: Ben Gardiner <bengardiner@nanometrics.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>, Sekhar Nori <nsekhar@ti.com>,
davinci-linux-open-source@linux.davincidsp.com,
James Nuss <jamesnuss@nanometrics.ca>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] davinci-mcasp: correct tdm_slots limit
Date: Tue, 26 Apr 2011 09:20:50 -0400 [thread overview]
Message-ID: <BANLkTimPzok1VCefK1GtNaLM+Tg0nrR9=Q@mail.gmail.com> (raw)
In-Reply-To: <20110426104635.GA13252@opensource.wolfsonmicro.com>
On Tue, Apr 26, 2011 at 6:46 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, Apr 21, 2011 at 02:19:01PM -0400, Ben Gardiner wrote:
>> The current check for the number of tdm-slots specified by platform data is
>> always true (x >= 2 || x <= 32); therefore the else branch that warns of an
>> incorrect number of slots can never be taken.
>
> Applied all of these. Please always try to ensure that your commit logs
> are consistent with the rest of the subsystem so they don't need to be
> rewritten.
Thanks, Mark, for taking the patches anyways (and Liam for the Ack's)
-- Sorry I forgot the 'ASoC' tag (I noticed this patch was committed
as 049cfaa ASoC: davinci-mcasp: correct tdm_slots limit).
Best Regards,
Ben Gardiner
---
Nanometrics Inc.
http://www.nanometrics.ca
next prev parent reply other threads:[~2011-04-26 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 18:19 [PATCH 0/4] davinci-mcasp: fix tdm_slots and CBM/CFS Ben Gardiner
2011-04-21 18:19 ` [PATCH 1/4] davinci-mcasp: correct tdm_slots limit Ben Gardiner
2011-04-26 10:46 ` Mark Brown
2011-04-26 13:20 ` Ben Gardiner [this message]
2011-04-21 18:19 ` [PATCH 2/4] davinci-mcasp: use bitfield definitions for PDIR Ben Gardiner
2011-04-21 18:19 ` [PATCH 3/4] davinci-mcasp: fix _CBM_CFS hw_params Ben Gardiner
2011-04-21 18:19 ` [PATCH 4/4] davinci-mcasp: fix _CBM_CFS pin directions Ben Gardiner
2011-04-26 8:16 ` [PATCH 0/4] davinci-mcasp: fix tdm_slots and CBM/CFS Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimPzok1VCefK1GtNaLM+Tg0nrR9=Q@mail.gmail.com' \
--to=bengardiner@nanometrics.ca \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=jamesnuss@nanometrics.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=nsekhar@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).