From: Hillf Danton <dhillf@gmail.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH] sched: fix priority leakage in pick_next_highest_task_rt()
Date: Tue, 17 May 2011 22:53:22 +0800 [thread overview]
Message-ID: <BANLkTimgmam0_yg+5a58T3R_NYM6RQLakQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTim=di8pbt1CzHjHYSC0SbtgJzbmkw@mail.gmail.com>
On Tue, May 17, 2011 at 10:28 AM, Yong Zhang <yong.zhang0@gmail.com> wrote:
> On Mon, May 16, 2011 at 8:55 PM, Hillf Danton <dhillf@gmail.com> wrote:
>> When picking the second highest RT task for a given runqueue, if no
>> task found after scanning the queue of priority == idx, the next idx
>> should also be checked even in case that next is already existing, or
>> the window of priority leakage could be opened.
>
> I don't see what kind of problem you patch will fix.
> And mind explaining how priority leakage could happen?
>
Hi Yong
If no task is found after scanning the list at array->queue + idx,
what should we operate on next?
And why is the list scanned?
thanks
Hillf
next prev parent reply other threads:[~2011-05-17 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 12:55 [PATCH] sched: fix priority leakage in pick_next_highest_task_rt() Hillf Danton
2011-05-17 2:28 ` Yong Zhang
2011-05-17 14:53 ` Hillf Danton [this message]
2011-05-18 1:14 ` Steven Rostedt
2011-05-18 2:17 ` Yong Zhang
2011-05-18 2:07 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimgmam0_yg+5a58T3R_NYM6RQLakQ@mail.gmail.com \
--to=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).