From: Wanlong Gao <wanlong.gao@gmail.com>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers, mfd: Remove unused variable 'val'
Date: Sat, 16 Apr 2011 21:02:33 +0800 [thread overview]
Message-ID: <BANLkTimkSx+ECO_-Tyzgr8LVY3F52TTJXA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=_vsX6Zx8b82FYWUy5WGxLdMBbMQ@mail.gmail.com>
On 4/16/11, Liu Yuan <namei.unix@gmail.com> wrote:
> Hi, Samuel, is there another similar fix already pending? I notice the
> latest[ Linus tree[0ebc115da3ed6740, Fri Apr 15 20:31:15 2011 -0700]
> still has this redundant variable.
>
> Thanks,
> Yuan
>
> On Sat, Apr 2, 2011 at 2:41 PM, Liu Yuan <namei.unix@gmail.com> wrote:
>> From: Liu Yuan <tailai.ly@taobao.com>
>>
>>
>> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
>> ---
>> drivers/mfd/wl1273-core.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/wl1273-core.c b/drivers/mfd/wl1273-core.c
>> index 04914f2..37af778 100644
>> --- a/drivers/mfd/wl1273-core.c
>> +++ b/drivers/mfd/wl1273-core.c
>> @@ -153,7 +153,6 @@ out:
>> */
>> static int wl1273_fm_set_volume(struct wl1273_core *core, unsigned int
>> volume)
>> {
>> - u16 val;
>> int r;
>>
>> if (volume > WL1273_MAX_VOLUME)
Hi Liu Yuan:
It has already fixed in the Samuel's for-next branch.
Cheers .
http://git.kernel.org/?p=linux/kernel/git/sameo/mfd-2.6.git;a=blobdiff;f=drivers/mfd/wl1273-core.c;h=d97a86945174519a6d333bf0527875b63537384d;hp=63d250d9a366aeac9b94ee99bba6b6040f1916f8;hb=f880ff3edc1a6f8cfa98b337dc121824c170164c;hpb=b2b1fc7407b7b989a7582b31e732f81cbc7e1d50
>> --
>> 1.7.1
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2011-04-16 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 6:41 [PATCH] drivers, mfd: Remove unused variable 'val' Liu Yuan
2011-04-16 9:46 ` Liu Yuan
2011-04-16 13:02 ` Wanlong Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimkSx+ECO_-Tyzgr8LVY3F52TTJXA@mail.gmail.com \
--to=wanlong.gao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namei.unix@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).