From: Grant Likely <grant.likely@secretlab.ca>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Baruch Siach <baruch@tkos.co.il>,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: reorganize drivers
Date: Sun, 5 Jun 2011 14:57:48 -0600 [thread overview]
Message-ID: <BANLkTimnqZzwMAH8nqr2hN55Lcmiznr6+Q@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=K-kP4wFd2PP3JkPVs9FEm1ebCBw@mail.gmail.com>
On Sun, Jun 5, 2011 at 7:12 AM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> Hi Baruch,
>
> On Sun, Jun 5, 2011 at 1:24 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>>> Though the spi_ prefix seems redundant considering the files are in
>>> 'spi' directory.
>>> Just a thought, no objection.
>>
>> When looking at the list of loaded modules (e.g. in an Oops message), the name
>> "spi_xilinx" is much more meaningful than just "xilinx", for example.
> Good catch.
> Perhaps we could get Makefile to build modules with spi_ prefix. Just
> like USB gadgets do ?
I don't think it's worth mucking about with <module_name>-y :=
filename.o when the filename can just be made the same as the module
name.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2011-06-05 20:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 7:18 [PATCH] spi: reorganize drivers Grant Likely
2011-06-05 7:43 ` Jassi Brar
2011-06-05 7:54 ` Baruch Siach
2011-06-05 11:49 ` Geert Uytterhoeven
2011-06-05 13:08 ` Stefan Richter
2011-06-05 20:55 ` Grant Likely
2011-06-05 21:19 ` Jassi Brar
2011-06-05 13:12 ` Jassi Brar
2011-06-05 20:57 ` Grant Likely [this message]
2011-06-05 8:13 ` Mika Westerberg
2011-06-05 14:37 ` Grant Likely
2011-06-06 9:00 ` Arnd Bergmann
2011-06-06 9:08 ` Dominik Brodowski
2011-06-06 9:08 ` Russell King - ARM Linux
2011-06-06 9:17 ` Jean Delvare
2011-06-06 9:29 ` James Bottomley
2011-06-06 11:21 ` Arnd Bergmann
2011-06-06 12:16 ` Jean Delvare
2011-06-06 12:35 ` Geert Uytterhoeven
2011-06-06 12:57 ` Arnd Bergmann
2011-06-06 13:44 ` Stefan Richter
2011-06-06 15:04 ` Arnd Bergmann
2011-06-06 10:01 ` Geert Uytterhoeven
2011-06-06 14:39 ` Grant Likely
2011-06-06 15:15 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2011-06-05 7:13 Grant Likely
2011-06-07 9:28 ` Linus Walleij
2011-06-07 13:26 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimnqZzwMAH8nqr2hN55Lcmiznr6+Q@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=baruch@tkos.co.il \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).