From: Hillf Danton <dhillf@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH] sched: remove noop in alloc_rt_sched_group()
Date: Sat, 23 Apr 2011 21:29:05 +0800 [thread overview]
Message-ID: <BANLkTin-FfQfqW5ym1iuEmrk8s777Y1LAg@mail.gmail.com> (raw)
The rq varible, though computed for each possible cpu, has nothing to
do in the function, so it could be removed.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/kernel/sched.c 2011-03-30 03:09:48.000000000 +0800
+++ b/kernel/sched.c 2011-04-23 21:23:48.000000000 +0800
@@ -8539,7 +8539,6 @@ int alloc_rt_sched_group(struct task_gro
{
struct rt_rq *rt_rq;
struct sched_rt_entity *rt_se;
- struct rq *rq;
int i;
tg->rt_rq = kzalloc(sizeof(rt_rq) * nr_cpu_ids, GFP_KERNEL);
@@ -8553,8 +8552,6 @@ int alloc_rt_sched_group(struct task_gro
ktime_to_ns(def_rt_bandwidth.rt_period), 0);
for_each_possible_cpu(i) {
- rq = cpu_rq(i);
-
rt_rq = kzalloc_node(sizeof(struct rt_rq),
GFP_KERNEL, cpu_to_node(i));
if (!rt_rq)
next reply other threads:[~2011-04-23 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-23 13:29 Hillf Danton [this message]
2011-04-23 14:12 ` [PATCH] sched: remove noop in alloc_rt_sched_group() Yong Zhang
2011-04-26 12:58 ` [tip:sched/core] sched: Remove " tip-bot for Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin-FfQfqW5ym1iuEmrk8s777Y1LAg@mail.gmail.com \
--to=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).