Re: [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV_KERNEL

["Américo Wang" <xiyou.wangcong@gmail.com>]

On Tue, Jun 7, 2011 at 6:11 AM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Mon, Jun 06, 2011 at 12:56:33PM +0200, Peter Oberparleiter wrote:
>> On 05.06.2011 10:21, Josh Triplett wrote:
>> >CONFIG_CONSTRUCTORS controls support for running constructor functions
>> >at kernel init time.  According to commit
>> >b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7, gcov (CONFIG_GCOV_KERNEL)
>> >needs this.  However, CONFIG_CONSTRUCTORS currently defaults to y, with
>> >no option to disable it, and CONFIG_GCOV_KERNEL depends on it.  Instead,
>> >default it to n and have CONFIG_GCOV_KERNEL select it, so that the
>> >normal case of CONFIG_GCOV_KERNEL=n will result in
>> >CONFIG_CONSTRUCTORS=n.
>> >
>> >Observed in the short list of =y values in a minimal kernel
>> >configuration.
>> >
>> >Signed-off-by: Josh Triplett<josh@joshtriplett.org>
>> >---
>>
>> I tested this patch and GCOV profiling still works with it applied.
>> To my knowledge, GCOV profiling is the only kernel mechanism using
>> GCC's constructors and this may save some bytes.
>>
>> Acked-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
>
> Excellent, thanks for testing and acking.
>
> What tree should this patch go through?
>

Andrew is supposed to take this. :)