From: richard -rw- weinberger <richard.weinberger@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Darren Hart" <dvhart@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: kernel 2.6.39 (user mode linux) crashes (2.6.38 works fine)
Date: Sun, 22 May 2011 01:06:46 +0200 [thread overview]
Message-ID: <BANLkTinswk09M7bOup01EnrTNQycNbUMDw@mail.gmail.com> (raw)
In-Reply-To: <1306017456.18455.1.camel@twins>
On Sun, May 22, 2011 at 12:37 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Sat, 2011-05-21 at 12:12 +0200, richard -rw- weinberger wrote:
>> 2011/5/21 Toralf Förster <toralf.foerster@gmx.de>:
>> > Bisecting gave :
>> >
>> >
>> > git bisect badd123375425d7df4b6081a631fc1203fceafa59b2 is the first bad commit
>> > commit d123375425d7df4b6081a631fc1203fceafa59b2
>> > Author: Thomas Gleixner <tglx@linutronix.de>
>> > Date: Wed Jan 26 21:32:01 2011 +0100
>> >
>> > rwsem: Remove redundant asmregparm annotation
>> >
>> > Peter Zijlstra pointed out, that the only user of asmregparm (x86) is
>> > compiling the kernel already with -mregparm=3. So the annotation of
>> > the rwsem functions is redundant. Remove it.
>>
>> Ok, this bisect makes much more sense.
>>
>> Thomas, Peter, please revert d123375425d7df4b6081a631fc1203fceafa59b2.
>> We cannot compile UML with -mregparm=3 it would cause a lot of trouble.
>> It would break 32bit UML on 64bit and also on older 32bit systems like RHEL5.
>
> But why?
Why reverting?
d123375 effectively reverts commit d50efc6c (x86: fix UML and -regparm=3).
> Also, having to carry that asmregparm notation just for uml doesn't seem
> worth the trouble.
>
Frankly, I don't know why exactly UML breaks without having asmregparm.
I've seen this -regparm=3 thing today the very first time, I'll dig into it...
--
Thanks,
//richard
next prev parent reply other threads:[~2011-05-21 23:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 13:26 kernel 2.6.39 (user mode linux) crashes (2.6.38 works fine) Toralf Förster
2011-05-19 16:34 ` Toralf Förster
2011-05-20 6:44 ` richard -rw- weinberger
2011-05-20 7:43 ` Toralf Förster
2011-05-19 17:00 ` richard -rw- weinberger
2011-05-19 17:20 ` Toralf Förster
2011-05-19 17:25 ` richard -rw- weinberger
2011-05-19 20:18 ` Toralf Förster
2011-05-19 20:43 ` Steven Rostedt
2011-05-20 7:37 ` Toralf Förster
2011-05-20 7:56 ` richard -rw- weinberger
2011-05-20 8:39 ` richard -rw- weinberger
2011-05-20 8:58 ` Toralf Förster
2011-05-20 9:02 ` richard -rw- weinberger
2011-05-20 9:19 ` Toralf Förster
2011-05-20 8:42 ` Toralf Förster
2011-05-20 16:24 ` richard -rw- weinberger
2011-05-20 17:19 ` Steven Rostedt
2011-05-20 15:55 ` Darren Hart
2011-05-20 16:04 ` Steven Rostedt
2011-05-20 16:11 ` Steven Rostedt
2011-05-20 17:10 ` Toralf Förster
2011-05-20 17:44 ` Steven Rostedt
2011-05-20 17:46 ` Steven Rostedt
2011-05-20 22:53 ` Toralf Förster
2011-05-21 8:53 ` Toralf Förster
2011-05-23 19:17 ` richard -rw- weinberger
2011-05-23 19:48 ` Toralf Förster
2011-05-21 10:12 ` richard -rw- weinberger
2011-05-21 22:37 ` Peter Zijlstra
2011-05-21 23:06 ` richard -rw- weinberger [this message]
2011-05-20 17:35 ` Darren Hart
2011-05-20 17:41 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinswk09M7bOup01EnrTNQycNbUMDw@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=dvhart@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=toralf.foerster@gmx.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).