public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Riley Williams" <Riley@Williams.Name>
To: "Andrew Morton" <akpm@digeo.com>, "Pavel Machek" <pavel@ucw.cz>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: 2.5.70: CODA breaks boot
Date: Wed, 28 May 2003 22:00:06 +0100	[thread overview]
Message-ID: <BKEGKPICNAKILKJKMHCACEPLEBAA.Riley@Williams.Name> (raw)
In-Reply-To: <20030528043600.650a2f82.akpm@digeo.com>

Hi Andrew.

 >> ...it oopses in kmem_cache_create, called from release_console_sem and
 >>  coda_init_inodecache.

 > You'll be needing this one.
 > 
 >  fs/coda/inode.c |    6 +++---
 >  1 files changed, 3 insertions(+), 3 deletions(-)
 > 
 > diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c
 > --- 25/fs/coda/inode.c~coda-typo-fix	2003-05-27 22:27:11.000000000 -0700
 > +++ 25-akpm/fs/coda/inode.c	2003-05-27 22:27:27.000000000 -0700
 > @@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c
 >  int coda_init_inodecache(void)
 >  {
 >  	coda_inode_cachep = kmem_cache_create("coda_inode_cache",
 > -					     sizeof(struct coda_inode_info),
 > +				sizeof(struct coda_inode_info),
 > -					     0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT,
 > +				0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
 > -					     init_once, NULL);
 > +				init_once, NULL);
 >  	if (coda_inode_cachep == NULL)
 >  		return -ENOMEM;
 >  	return 0;

That patch has me puzzled. Other than changing the white space, what actual
change to the code does it make? I can't see any.

Best wishes from Riley.
---
 * Nothing as pretty as a smile, nothing as ugly as a frown.

---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.484 / Virus Database: 282 - Release Date: 27-May-2003


  reply	other threads:[~2003-05-28 20:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-28 11:24 2.5.70: CODA breaks boot Pavel Machek
2003-05-28 11:36 ` Andrew Morton
2003-05-28 21:00   ` Riley Williams [this message]
2003-05-28 21:05     ` Randy.Dunlap
2003-05-28 21:08     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BKEGKPICNAKILKJKMHCACEPLEBAA.Riley@Williams.Name \
    --to=riley@williams.name \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox