From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CA8C83F25 for ; Wed, 30 Aug 2023 19:29:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344188AbjH3T0p convert rfc822-to-8bit (ORCPT ); Wed, 30 Aug 2023 15:26:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244997AbjH3OTg (ORCPT ); Wed, 30 Aug 2023 10:19:36 -0400 Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [5.144.164.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 565A8122 for ; Wed, 30 Aug 2023 07:19:32 -0700 (PDT) Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 635EC20035; Wed, 30 Aug 2023 16:19:29 +0200 (CEST) Date: Wed, 30 Aug 2023 16:19:23 +0200 From: Martin Botka Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions To: Sudeep Holla Cc: Mark Rutland , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka Message-Id: In-Reply-To: References: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patches using this are still WIP but the basic point is that H616 has 2 die revisions (And those have couple of other versions themselves) that require different uV and some frequencies are blacklisted on those versions. The driver is using these functions to read the revision (Not the version. It just looked like the logical thing to export both and Andre confirmed. We can ofc drop the version symbol export if need be) and reads trough the OPP table and selects the supported frequencies and uV for the chip its running on :) I will try to get the cpufreq patches in order in the upcoming days and I will Cc you in those as well + post a link to them in this thread :) Cheers, Martin On Wed, Aug 30 2023 at 03:05:09 PM +01:00:00, Sudeep Holla wrote: > > > On Wed, Aug 30, 2023 at 2:24 PM Martin Botka > wrote: >> arm_smccc_get_soc_id_version and arm_smccc_get_soc_id_revision >> need to be exported so they can be used by modules. >> Currently sun50i cpu freq driver is planning to use these functions. > > I am not against exporting these but please post along with the > patches using these > exported symbols so that no one complains about you exporting the > symbols mentioning > some patches that may or may not appear in the future. > > -- > Regards, > Sudeep