Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

Chris Wright
2007-03-16T16:59:55Z

* Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> Chris Wright wrote:
> > That's been fixed, the two are built as seperate objects now.
>
> Actually, we tried it but it causes bad kernel images with some
> binutils, so it has to be included for now.

Ah, missed that.

> >>> @@ -437,9 +437,9 @@ static unsigned long native_store_tr(voi
> >>>
> >>> static void native_load_tls(struct thread_struct *t, unsigned int cpu)
> >>> {
> >>> -#define C(i) get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + i] = t->tls_array[i]
> >>> - C(0); C(1); C(2);
> >>> -#undef C
> >>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 0] = t->tls_array[0];
> >>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 1] = t->tls_array[1];
> >>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 2] = t->tls_array[2];
> >>> }
> >>>
> >> this is a cleanup unrelated to the purpose of the patch.
> >>
> >
> > Sure, will split out.
> >
>
> Already done in Rusty's cleanup patch.

Hmm, not here, I'll fix it up.

thanks,
-chris