From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Andy Chou <acc@CS.Stanford.EDU>
Cc: alan@lxorguk.ukuu.org.uk,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mc@cs.stanford.edu
Subject: Re: [CHECKER] 24 more buffer overruns in 2.5.48
Date: Fri, 3 Jan 2003 12:34:51 +0100 [thread overview]
Message-ID: <C2B6EB553C4@vcnet.vc.cvut.cz> (raw)
On 2 Jan 03 at 19:06, Andy Chou wrote:
> > > void do_install_cmap(int con, struct fb_info *info)
> > > {
> > > if (con != info->currcon)
> > > return;
> >
> > currcon can never be -1. I don't think the compiler can ever deduce that
> > detail though.
With matroxfb (and dozen of other fbdevs) currcon can be -1 (with matroxfb
currcon can be even -2 during probe, so con != info->currcon tests always
fail...) when there is no VT attached to the fbdev. That's why matroxfb
uses my_install_cmap instead of generic one.
It should be no issue in 2.5.54 though, as there is no install_cmap
anymore...
Petr Vandrovec
next reply other threads:[~2003-01-03 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-03 11:34 Petr Vandrovec [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-01-03 0:37 [CHECKER] 24 more buffer overruns in 2.5.48 Andy Chou
2003-01-03 1:53 ` Alan Cox
2003-01-03 3:06 ` Andy Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2B6EB553C4@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=acc@CS.Stanford.EDU \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox