Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

Andi Kleen
2007-11-22T03:37:22Z

> I like this concept in general; I have one minor comment; right now
> your namespace argument is like
>
> EXPORT_SYMBOL_NS(foo, some_symbol);
>
> from a language-like pov I kinda wonder if it's nicer to do
>
> EXPORT_SYMBOL_NS("foo", some_symbol);
>
> because foo isn't something in C scope, but more a string-like
> identifier...

That wouldn't work for MODULE_ALLOW() because it appends the namespace
to other identifiers. I don't know of a way in the C processor to get
back from a string to a ## concatenable identifier.

For EXPORT_SYMBOL_NS it would be in theory possible, but making
it asymmetric to MODULE_ALLOW would be ugly imho.

-Andi